Upgrade OpenModelica & MBL #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tests failing? should I wait until that gets resolved to review? |
No, please review now. The tests are failing because in modelica_runner.py I'm referring to an image that doesn't exist yet. Will you please:
Once those are good, I can re-run CI and once we have all green you can approve and we can merge it. |
nllong
approved these changes
Oct 27, 2024
nllong
requested changes
Oct 27, 2024
* use MBLv11 paths in templates * experiment with new Ubuntu and OM versions * use OM 1.23.0 with Ubuntu 20 in Dockerfile * update dependencies * more code/template changes to work with MBLv11 * update Dockerfile to load new MBL version * go back to what OM has in their Dockerfile (mostly) * cleaned up Dockerfile after Netskope shenanigans * even newer dependency versions [skip ci] * document the MBL version in the runner readme * update mbl version in CI * bump gmt version, and use modelica-builder branch * bump dependencies * update modelica runner readme * point to docker image that only exists on my computer * read mbl version from utils function * bump pre-commit hook versions * linting * bump dependencies * redeclare ETS type and update variable name to fix broken tests due to version change * change the required mo file name * replace the mo file with the new version in MBLv11 * update function path * new pump controller parameter input * connect statements for new pump controller * remove parameters no longer needed * additional parameters required by distribution 2 pipe * update path for terUni * update paths and add dis * new required parameter for pump control * pre-commit changes * compile msl test creates fmu one dir up from results dir * pre-commit Modelica formatter changed some things * reminder note to release MB in conjunction with this * text fixes --------- Co-authored-by: Jing Wang <[email protected]> Co-authored-by: Nicholas Long <[email protected]>
* use MBLv11 paths in templates * experiment with new Ubuntu and OM versions * use OM 1.23.0 with Ubuntu 20 in Dockerfile * update dependencies * more code/template changes to work with MBLv11 * update Dockerfile to load new MBL version * go back to what OM has in their Dockerfile (mostly) * cleaned up Dockerfile after Netskope shenanigans * even newer dependency versions [skip ci] * document the MBL version in the runner readme * update mbl version in CI * bump gmt version, and use modelica-builder branch * bump dependencies * update modelica runner readme * point to docker image that only exists on my computer * read mbl version from utils function * bump pre-commit hook versions * linting * bump dependencies * redeclare ETS type and update variable name to fix broken tests due to version change * change the required mo file name * replace the mo file with the new version in MBLv11 * update function path * new pump controller parameter input * connect statements for new pump controller * remove parameters no longer needed * additional parameters required by distribution 2 pipe * update path for terUni * update paths and add dis * new required parameter for pump control * pre-commit changes * change class of the district pump * update mass flow rate in datDes * add pump and controller to borefield instance * modify medium and parameter redeclaration * add district supply and return sensors for control * connect statements for each borefield * pre-commit changes * rename file * remove unused input file * use renamed input file * fix class name * bug fix * fix connection of QCoo_flow * increase pump head for multi-ghe * remove test_borefield and the corresponding coupling --------- Co-authored-by: Nathan Moore <[email protected]>
nllong
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any background context you want to provide?
A new version of OpenModelica was recently released. We can now take advantage of their "many improvements and bug fixes" in this newest version.
What does this PR accomplish?
cmaketo a different part of the Dockerfile to be as similar as possible to the OM Dockerfile ours is modeled onHow should this be manually tested?
2.1.03.0.0(@nllong is that the right version for this change?)What are the relevant tickets?
Screenshots (if appropriate)