Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow skipping GeoJSON validation #681

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

nllong
Copy link
Member

@nllong nllong commented Dec 14, 2024

Any background context you want to provide?

In some cases, the GeoJSON can contain extra information that is not problematic with the generation of the DES systems.

What does this PR accomplish?

  • allow skipping geojson validation. This should be considered an advance feature.

How should this be manually tested?

Code review should suffice

@nllong nllong requested a review from vtnate December 14, 2024 15:02
Copy link
Contributor

@vtnate vtnate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kwargs and not an explicit skip_validation like you did in urbanopt_geojson?

LGTM 👍

@nllong
Copy link
Member Author

nllong commented Dec 16, 2024

at some point we should fix the issue that we have two GeoJSON classes. One in the GMT and one in URBANopt-DES. I think the only logically approach is to have UO-DES use the version in GMT... so we'd have to move some functionality over to GMT. Thanks for reviewing this so quickly!

@nllong nllong merged commit af549e2 into develop Dec 16, 2024
10 checks passed
@nllong nllong deleted the allow-skip-geojson-valid branch December 16, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants