Корабельникова Татьяна #82
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🍏 Пройден линтинг и базовые тесты |
Mokoshka
requested changes
Nov 3, 2017
| { | ||
| font-family: 'Nothing You Could Do', cursive; | ||
| font-size: 30px; | ||
| font-weight: 100; |
There was a problem hiding this comment.
Почему бы не объединить в одно правило, как сделано выше?
|
|
||
| .statement | ||
| { | ||
| display: block; |
There was a problem hiding this comment.
Вот здесь какой-то адок. Ты вставляешь span в p и делаешь из span блочный элемент. Зачем?
| <label for="color-light">light</label> | ||
| <input type="radio" name="color" id="color-light" checked="checked"> | ||
| <label for="color-dark">dark</label> | ||
| <input type="radio" name="color" id="color-dark"> |
There was a problem hiding this comment.
Давай сверстаем элементы управления стилями газеты без использования br
| <section> | ||
| <article class="column"> | ||
| <figure class="sign"> | ||
| <img src="http://goo.gl/qp2hFa" alt="Elvis Costello"> |
| </p> | ||
| </article> | ||
| </section> | ||
| <section> |
There was a problem hiding this comment.
Нужно ли делать обертку в виде section? Почему не поставить два article в одном section?
| <article class="column"> | ||
| <p class="song-title">A Day in the Life</p> | ||
| <figure class="sign"> | ||
| <img class="image" src="http://goo.gl/E1pOcJ" alt="Beatles"> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Посмотреть решение