Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI #116

Merged
merged 9 commits into from
Dec 3, 2024
Merged

UI #116

merged 9 commits into from
Dec 3, 2024

Conversation

cptKNJO
Copy link
Contributor

@cptKNJO cptKNJO commented Dec 1, 2024

This PR adds the following features:

  • Add side menu entry for backups
  • Adds backups pages to first show a client list, then the backups a client has, then allow browsing files in backup using the component
  • Add Download folder as ZIP button on the bottom for folders
  • Add list and if required restore buttons for folders and files (do nothing yet)
  • Download the file when clicking on a file via setting location.href to downloadFileURL
  • Show archived backups as archived. If they have an archive timeout show that as well
  • Have buttons to archive, delete, unarchive a backup using the archiveBackup, unarchiveBackup and deleteBackup functions
  • Show backups that are pending delete with a stop delete button (calling stopDeleteBackup)
  • Show delete now button calling deleteBackupNow

Screenshots

Backups page

Screenshot from 2024-12-01 19-53-11

Client backups page

Screenshot from 2024-12-01 19-49-58

If archive timeout exists

Screenshot from 2024-11-27 23-33-47

Backup folder page

Screenshot from 2024-12-01 19-51-05

Note

I have added a dummy List button for backup folders/files. But I haven't seen Restore button used anywhere in the app. Please let me know how to trigger it if relevant.

This PR does not include the new features of the backups page (part of a future PR):

  • Add a filter text box that filters the entries to contain the text entered (like on the status table)
  • Pagination. If there are a lot of entries it should distribute them to multiple pages

Copy link
Owner

@uroni uroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great!

@cptKNJO
Copy link
Contributor Author

cptKNJO commented Dec 2, 2024

Thank you for your review! Added commits with some changes based on review.

@uroni uroni merged commit 7178d99 into uroni:dev Dec 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants