Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update build file to create 2 versions (es5 and raw one) #1190

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

miloszsobczak
Copy link

Not everyone wants to use default babelified version of the package due to multiple reasons:

  • modern browser support
  • willingness to use smaller version of the file (in this case twice smaller than original one)
  • existence of potential conflict with already embedded core-js library on the page

So I decided to push some change that will be still compatible with current version (as main file in package.json has been changed too). If someone wants to use raw code wirtten in UMD style I believe it can be truly beneficial for wider audience.

Let me know what do you think.
The code itself it is not super sophisticated, it just the matter of rollup configuration.

Copy link
Contributor

@afshinm afshinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

@@ -16,7 +16,7 @@
"type": "git",
"url": "https://github.com/usablica/intro.js"
},
"main": "intro.js",
"main": "intro.es5.js",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if changing the default main entrypoint is a good idea right now. Not entirely sure how this would affect people. Could you please revert this? You should still have access to the intro.es5.js in the npm package/CDNs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants