Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add scrollElRef to support custom scroll element view #1877

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

clemdesign
Copy link

I propose this PR in order to add options scrollElRef which support a custom scroll element view.

This one can be defined in global options set or in step options.

Where defined, the scroll action is defined on the element instead to be determinated by getParentScroll().

It useful typically in Ionic application where shadow container is defined and getParentScroll() not detect the scroll element. I tried to build a sample but not fully operational in Ionic-like context.

@afshinm
Copy link
Contributor

afshinm commented Mar 23, 2023

@clemdesign Sounds good. Could you rebase your branch please?

@vercel
Copy link

vercel bot commented Mar 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
intro-js ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 23, 2023 at 0:21AM (UTC)

@clemdesign
Copy link
Author

@afshinm done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants