Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert the library to use Signals and reactive elements #2075

Merged
merged 59 commits into from
Sep 11, 2024
Merged
Show file tree
Hide file tree
Changes from 58 commits
Commits
Show all changes
59 commits
Select commit Hold shift + click to select a range
65f4a60
adding the basic dom package
binrysearch Jul 28, 2024
003ab2a
tag tests
binrysearch Jul 28, 2024
ebd5c7b
add tests
binrysearch Jul 28, 2024
f3740e2
derived tests
binrysearch Jul 28, 2024
9bf4138
derived tests
binrysearch Jul 28, 2024
afabeaf
hydrate tests
binrysearch Jul 28, 2024
2aa0b88
gc tests
binrysearch Jul 28, 2024
557c645
e2e tests
binrysearch Jul 28, 2024
9c7a2ff
prettier
binrysearch Jul 28, 2024
3a46f5c
Replace hint tooltip with the reactive version
binrysearch Aug 20, 2024
c58d62e
HintTooltip
binrysearch Sep 1, 2024
c078182
tourTooltip
binrysearch Sep 1, 2024
da7fc24
complete tourTooltip
binrysearch Sep 1, 2024
4cb8b97
Fix tooltip transitions
binrysearch Sep 2, 2024
4f6e298
remove unused code
binrysearch Sep 2, 2024
b4c27c5
add root
binrysearch Sep 3, 2024
7e278ec
helperLayer
binrysearch Sep 4, 2024
f52d74b
overlayLayer
binrysearch Sep 4, 2024
0643c7d
complete referenceLayer and scroll
binrysearch Sep 4, 2024
718c4fd
disableInteraction
binrysearch Sep 4, 2024
9e73d8e
add TourRoot
binrysearch Sep 4, 2024
4ba62d4
fix helperLayer transition
binrysearch Sep 5, 2024
fced29b
Update currentStep
binrysearch Sep 5, 2024
067a7c0
pass Step to downstream components instead of State
binrysearch Sep 5, 2024
5171c76
fix transition
binrysearch Sep 5, 2024
4db5719
fix the tooltip transition
binrysearch Sep 5, 2024
9d2c558
fix progress bar and next button focus
binrysearch Sep 5, 2024
7400e1b
fix exitIntro tests
binrysearch Sep 7, 2024
aaedaf0
Add FloatingElement
binrysearch Sep 8, 2024
adf01be
Fix the showElement bug in previous step
binrysearch Sep 8, 2024
41c1f25
remove unused
binrysearch Sep 8, 2024
7e2233d
fix resize and refresh steps
binrysearch Sep 8, 2024
edc92ca
remove unused placeTooltip
binrysearch Sep 8, 2024
9c6b72b
HintsRoot
binrysearch Sep 8, 2024
a4bf005
hint position
binrysearch Sep 8, 2024
dddc711
fix hint onclicks
binrysearch Sep 8, 2024
83345c7
update hint API
binrysearch Sep 8, 2024
667d314
rename
binrysearch Sep 8, 2024
62af205
remove unused
binrysearch Sep 8, 2024
d68ed0a
util unit tests
binrysearch Sep 9, 2024
6fd5727
refresh unit tests
binrysearch Sep 9, 2024
7949b33
refresh unit tests
binrysearch Sep 9, 2024
e970c32
start and steps tests
binrysearch Sep 9, 2024
b5b5b57
tour tests
binrysearch Sep 9, 2024
fd12b20
tooltip tests
binrysearch Sep 9, 2024
b37ae7c
delete setAnchorAsButton
binrysearch Sep 9, 2024
fa44e6e
rename dom package
binrysearch Sep 9, 2024
4139027
Fix hint toggle
binrysearch Sep 10, 2024
b49fc32
do not recreate root twice in tour
binrysearch Sep 10, 2024
19447e5
highlight.cy
binrysearch Sep 10, 2024
0eec7fc
Fix incorrect progress calc
binrysearch Sep 10, 2024
62103b1
upgrade cypress-visual-regression
binrysearch Sep 10, 2024
85f0d52
fix the env for cypress-visual-regressiob
binrysearch Sep 10, 2024
377e76f
set correct default in tooltip
binrysearch Sep 10, 2024
dffd357
set correct default in tooltip
binrysearch Sep 10, 2024
9ccc18e
remove diff snapshots + increase visual regression error thresold
binrysearch Sep 11, 2024
3b688c0
Fix incorrect tooltipBottomOverflow
binrysearch Sep 11, 2024
e60e1bd
prettier
binrysearch Sep 11, 2024
3158ec0
getOffset.test
binrysearch Sep 11, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cypress.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,10 @@ import { defineConfig } from "cypress";
import { configureVisualRegression } from "cypress-visual-regression";

module.exports = defineConfig({
viewportWidth: 1000,
trashAssetsBeforeRuns: true,
env: {
failSilently: false,
visualRegressionFailSilently: false,
},
e2e: {
screenshotsFolder: "./cypress/snapshots/actual",
Expand Down
8 changes: 4 additions & 4 deletions cypress/setup/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,15 @@
crossorigin="anonymous"
/>

<link href="http://localhost:10001/dist/introjs.css" rel="stylesheet" />
<link href="http://host.docker.internal:10001/dist/introjs.css" rel="stylesheet" />

<link rel="preconnect" href="https://fonts.gstatic.com" />
<link
href="https://fonts.googleapis.com/css2?family=Roboto&display=swap"
rel="stylesheet"
/>

<link href="http://localhost:10001/dist/introjs.css" rel="stylesheet" />
<link href="http://host.docker.internal:10001/dist/introjs.css" rel="stylesheet" />

<style type="text/css">
body,
h1,
Expand Down Expand Up @@ -157,7 +157,7 @@ <h2 data-intro="fourth header step" data-hint="secondary header">
class="pt-3 mt-4 text-muted border-top"
data-hint="this is the footer"
>
&copy; YEAR
&copy; 2021
</footer>
</div>
</main>
Expand Down
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
1 change: 1 addition & 0 deletions cypress/support/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { addCompareSnapshotCommand } from "cypress-visual-regression/dist/comman

addCompareSnapshotCommand({
capture: "fullPage",
errorThreshold: 0.09
});

Cypress.Commands.add("nextStep", () => {
Expand Down
14 changes: 7 additions & 7 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"test:prettier": "prettier --check '(src|tests)/**/*.(js|ts|json|html)' '!tests/cypress/setup/dist'",
"test:watch": "jest --watch",
"test:jest": "jest --coverage --silent --ci --coverage --coverageReporters=\"text\" --coverageReporters=\"text-summary\"",
"test:cypress": "start-server-and-test dev http://localhost:10001/dist/intro.js 'docker run -it -v $PWD:/e2e -w /e2e --entrypoint=cypress cypress/included run --env type=regression || cypress run --env type=regression'",
"test:cypress": "start-server-and-test dev http://localhost:10001/dist/intro.js 'docker run -it -v $PWD:/e2e -w /e2e --entrypoint=cypress cypress/included run --env visualRegressionType=regression || cypress run --env visualRegressionType=regression'",
"release": "./bin/release.sh || true",
"prebuild": "rimraf ./dist",
"build": "rollup -c",
Expand All @@ -48,7 +48,7 @@
"core-js": "^3.6.5",
"cypress": "^13.12.0",
"cypress-real-events": "^1.13.0",
"cypress-visual-regression": "^5.0.2",
"cypress-visual-regression": "^5.2.1",
"eslint": "^8.0.1",
"jest": "^29.5.0",
"jest-extended": "^3.2.4",
Expand Down
Loading
Loading