Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.4.0 #23

Merged
merged 1 commit into from
Jun 23, 2024
Merged

v0.4.0 #23

merged 1 commit into from
Jun 23, 2024

Conversation

usbalbin
Copy link
Owner

@usbalbin usbalbin commented Jun 16, 2024

v0.4.0

Breaking

  • feat(breaking): make FromIteratorFixed more generic #21 Update FromIteratorFixed trait to avoid unnameable iterator type as type paramater in the trait
    - pub trait FromIteratorFixed<I: Iterator, const N: usize> {
    -     fn from_iter_fixed(iter_fixed: IteratorFixed<I, N>) -> Self;
    + pub trait FromIteratorFixed<T, const N: usize> {
    +     fn from_iter_fixed<I: Iterator<Item = T>>(iter_fixed: IteratorFixed<I, N>) -> Self;
      }

Other changes

Thank you

@gwen-lg
Copy link
Contributor

gwen-lg commented Jun 16, 2024

perhaps list changes and the fact than can break use ?
In commit and PR descriptions ?

@gwen-lg
Copy link
Contributor

gwen-lg commented Jun 16, 2024

Oh, I'm thinking about it.
Clippy also say "missing documentation for the crate"
from https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items

Perhaps it could be good to have one, to have more information on doc.
But I was not sure about what to say and avoid copy past of Readme or part of it.

@Daniel-Aaron-Bloom
Copy link
Contributor

I mean, you could copy the readme and use something like https://crates.io/crates/cargo-readme to make sure they don't get out of sync.

@usbalbin
Copy link
Owner Author

usbalbin commented Jun 16, 2024

Perhaps there is a better way, but what about using cargo-readme to create a temporary file and something like diff to see if the committed README.md is up to date as part of the ci workflow?

@usbalbin usbalbin force-pushed the bump_version branch 2 times, most recently from fe9db23 to 62a977f Compare June 23, 2024 21:26
 ## Breaking
* #21 -feat(breaking): make FromIteratorFixed more generic
  Update `FromIteratorFixed` trait to avoid
  unnameable iterator type as type paramater in the trait

 ## Other changes

* #22 - Some cleaning from additional clippy lints
* #20 - fix: nightly flags and clippy warnings
* #24 - Migrate to use cargo readme
* #25 - Use cargo readme in ci

 ## Thank you
* @Daniel-Aaron-Bloom
* @gwen-lg
@usbalbin usbalbin merged commit d664bbf into master Jun 23, 2024
15 checks passed
@usbalbin
Copy link
Owner Author

Thank you both :)

@usbalbin usbalbin deleted the bump_version branch June 23, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants