-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Lambda monitors to query by functionname
tag
#390
Merged
TylerHendrickson
merged 3 commits into
main
from
feat/use-functionname-tag-for-monitor-queries
Oct 12, 2023
Merged
Update Lambda monitors to query by functionname
tag
#390
TylerHendrickson
merged 3 commits into
main
from
feat/use-functionname-tag-for-monitor-queries
Oct 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terraform Summary
OutputValidation Output
Plan OutputTerraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
~ update in-place
-/+ destroy and then create replacement
Terraform will perform the following actions:
# datadog_dashboard.service_dashboard[0] will be updated in-place
~ resource "datadog_dashboard" "service_dashboard" {
id = "4jj-dh7-k8z"
tags = []
# (9 unchanged attributes hidden)
~ template_variable {
- default = "production" -> null
~ defaults = [
+ "production",
]
name = "env"
# (2 unchanged attributes hidden)
}
~ template_variable {
- default = "grants-ingest" -> null
~ defaults = [
+ "grants-ingest",
]
name = "service"
# (2 unchanged attributes hidden)
}
~ template_variable {
- default = "*" -> null
~ defaults = [
+ "*",
]
name = "version"
# (2 unchanged attributes hidden)
}
~ widget {
id = 905112177242094
~ group_definition {
# (3 unchanged attributes hidden)
- widget {
- id = 252964521945204 -> null
- list_stream_definition {
- title = "Log Transactions by Function" -> null
- title_align = "left" -> null
- title_size = "16" -> null
- request {
- response_format = "event_list" -> null
- columns {
- field = "group_by" -> null
- width = "auto" -> null
}
- columns {
- field = "count:count" -> null
- width = "auto" -> null
}
- columns {
- field = "@lambda.memory_pct:max" -> null
- width = "auto" -> null
}
- columns {
- field = "max_severity" -> null
- width = "auto" -> null
}
- columns {
- field = "timeline" -> null
- width = "auto" -> null
}
- query {
- data_source = "logs_transaction_stream" -> null
- indexes = [] -> null
- query_string = "$service $env" -> null
}
}
}
- widget_layout {
- height = 4 -> null
- is_column_break = false -> null
- width = 8 -> null
- x = 0 -> null
- y = 6 -> null
}
}
- widget {
- id = 6325623311911406 -> null
- list_stream_definition {
- title = "Latest Errors" -> null
- title_align = "left" -> null
- title_size = "16" -> null
- request {
- response_format = "event_list" -> null
- columns {
- field = "details" -> null
- width = "auto" -> null
}
- columns {
- field = "count" -> null
- width = "auto" -> null
}
- columns {
- field = "volume" -> null
- width = "auto" -> null
}
- query {
- data_source = "apm_issue_stream" -> null
- indexes = [] -> null
- query_string = "$service $env" -> null
}
}
}
- widget_layout {
- height = 4 -> null
- is_column_break = false -> null
- width = 4 -> null
- x = 8 -> null
- y = 6 -> null
}
}
# (2 unchanged blocks hidden)
}
~ widget_layout {
~ height = 11 -> 6
# (4 unchanged attributes hidden)
}
}
~ widget {
id = 8574259735760031
~ widget_layout {
~ height = 4 -> 3
~ y = 11 -> 6
# (3 unchanged attributes hidden)
}
# (1 unchanged block hidden)
}
~ widget {
id = 163359234830345
~ group_definition {
# (3 unchanged attributes hidden)
- widget {
- id = 4488472111424862 -> null
- timeseries_definition {
- legend_columns = [
- "avg",
- "max",
- "min",
- "sum",
- "value",
] -> null
- legend_layout = "auto" -> null
- show_legend = true -> null
- title = "Log Volume by Level" -> null
- title_align = "left" -> null
- title_size = "16" -> null
- request {
- display_type = "bars" -> null
- on_right_yaxis = false -> null
- formula {
- formula_expression = "query1" -> null
}
- query {
- event_query {
- data_source = "logs" -> null
- indexes = [
- "*",
] -> null
- name = "query1" -> null
- storage = "hot" -> null
- compute {
- aggregation = "count" -> null
- interval = 0 -> null
}
- group_by {
- facet = "status" -> null
- limit = 10 -> null
- sort {
- aggregation = "count" -> null
- order = "desc" -> null
}
}
- search {
- query = "$env $service functionname:grants_ingest-downloadgrantsgovdb" -> null
}
}
}
- style {
- line_type = "solid" -> null
- line_width = "normal" -> null
- palette = "semantic" -> null
}
}
}
- widget_layout {
- height = 3 -> null
- is_column_break = false -> null
- width = 4 -> null
- x = 0 -> null
- y = 3 -> null
}
}
- widget {
- id = 1397511323101690 -> null
- timeseries_definition {
- legend_columns = [
- "avg",
- "max",
- "min",
- "sum",
- "value",
] -> null
- legend_layout = "horizontal" -> null
- show_legend = true -> null
- title = "Log Volume - Warn & Error" -> null
- title_align = "left" -> null
- title_size = "16" -> null
- request {
- display_type = "bars" -> null
- on_right_yaxis = false -> null
- formula {
- formula_expression = "query1" -> null
}
- query {
- event_query {
- data_source = "logs" -> null
- indexes = [
- "*",
] -> null
- name = "query1" -> null
- storage = "hot" -> null
- compute {
- aggregation = "count" -> null
- interval = 0 -> null
}
- group_by {
- facet = "status" -> null
- limit = 10 -> null
- sort {
- aggregation = "count" -> null
- order = "desc" -> null
}
}
- search {
- query = "$env $service functionname:grants_ingest-downloadgrantsgovdb status:warn status:error" -> null
}
}
}
- style {
- line_type = "solid" -> null
- line_width = "normal" -> null
- palette = "semantic" -> null
}
}
}
- widget_layout {
- height = 3 -> null
- is_column_break = false -> null
- width = 4 -> null
- x = 4 -> null
- y = 3 -> null
}
}
- widget {
- id = 3129096132845224 -> null
- sunburst_definition {
- hide_total = false -> null
- title = "Total Logs by Level" -> null
- title_align = "left" -> null
- title_size = "16" -> null
- legend_table {}
- request {
- formula {
- formula_expression = "query1" -> null
- limit {
- count = 0 -> null
- order = "desc" -> null
}
}
- query {
- event_query {
- data_source = "logs" -> null
- indexes = [
- "*",
] -> null
- name = "query1" -> null
- storage = "hot" -> null
- compute {
- aggregation = "count" -> null
- interval = 0 -> null
}
- group_by {
- facet = "status" -> null
- limit = 10 -> null
- sort {
- aggregation = "count" -> null
- order = "desc" -> null
}
}
- search {
- query = "$env $service functionname:grants_ingest-downloadgrantsgovdb" -> null
}
}
}
- style {
- palette = "semantic" -> null
}
}
}
- widget_layout {
- height = 3 -> null
- is_column_break = false -> null
- width = 4 -> null
- x = 8 -> null
- y = 3 -> null
}
}
- widget {
- id = 4819244188305672 -> null
- list_stream_definition {
- title = "Log Patterns" -> null
- title_align = "left" -> null
- title_size = "16" -> null
- request {
- response_format = "event_list" -> null
- columns {
- field = "status_line" -> null
- width = "auto" -> null
}
- columns {
- field = "matches" -> null
- width = "auto" -> null
}
- columns {
- field = "volume" -> null
- width = "auto" -> null
}
- columns {
- field = "status" -> null
- width = "auto" -> null
}
- columns {
- field = "message" -> null
- width = "auto" -> null
}
- query {
- data_source = "logs_pattern_stream" -> null
- indexes = [] -> null
- query_string = "$service $env functionname:grants_ingest-downloadgrantsgovdb" -> null
}
}
}
- widget_layout {
- height = 4 -> null
- is_column_break = false -> null
- width = 6 -> null
- x = 0 -> null
- y = 6 -> null
}
}
- widget {
- id = 4764868472286812 -> null
- list_stream_definition {
- title = "Invocation Logs (newest first)" -> null
- title_align = "left" -> null
- title_size = "16" -> null
- request {
- response_format = "event_list" -> null
- columns {
- field = "group_by" -> null
- width = "auto" -> null
}
- columns {
- field = "duration" -> null
- width = "auto" -> null
}
- columns {
- field = "count:count" -> null
- width = "auto" -> null
}
- columns {
- field = "max_severity" -> null
- width = "auto" -> null
}
- query {
- data_source = "logs_transaction_stream" -> null
- indexes = [] -> null
- query_string = "$env $service functionname:grants_ingest-downloadgrantsgovdb" -> null
- sort {
- column = "timeline" -> null
- order = "desc" -> null
}
}
}
}
- widget_layout {
- height = 4 -> null
- is_column_break = false -> null
- width = 6 -> null
- x = 6 -> null
- y = 6 -> null
}
}
- widget {
- id = 3293583303146954 -> null
- list_stream_definition {
- title = "Sampled Traces" -> null
- title_align = "left" -> null
- title_size = "16" -> null
- request {
- response_format = "event_list" -> null
- columns {
- field = "timestamp" -> null
- width = "auto" -> null
}
- columns {
- field = "@duration" -> null
- width = "auto" -> null
}
- columns {
- field = "span_count" -> null
- width = "auto" -> null
}
- columns {
- field = "latency_breakdown" -> null
- width = "auto" -> null
}
- columns {
- field = "status" -> null
- width = "auto" -> null
}
- columns {
- field = "error.type" -> null
- width = "auto" -> null
}
- columns {
- field = "@version" -> null
- width = "auto" -> null
}
- query {
- data_source = "trace_stream" -> null
- indexes = [] -> null
- query_string = "@_top_level:1 $env $service @functionname:grants_ingest-downloadgrantsgovdb" -> null
}
}
}
- widget_layout {
- height = 3 -> null
- is_column_break = false -> null
- width = 12 -> null
- x = 0 -> null
- y = 10 -> null
}
}
# (3 unchanged blocks hidden)
}
~ widget_layout {
~ height = 14 -> 3
~ y = 15 -> 9
# (3 unchanged attributes hidden)
}
}
~ widget {
id = 6228929852081327
~ widget_layout {
~ height = 4 -> 3
~ y = 29 -> 12
# (3 unchanged attributes hidden)
}
# (1 unchanged block hidden)
}
~ widget {
id = 5454968337730131
~ widget_layout {
~ height = 4 -> 3
~ y = 33 -> 15
# (3 unchanged attributes hidden)
}
# (1 unchanged block hidden)
}
~ widget {
id = 6649598959313552
~ widget_layout {
~ height = 4 -> 3
~ y = 37 -> 18
# (3 unchanged attributes hidden)
}
# (1 unchanged block hidden)
}
~ widget {
id = 7422900440689318
~ widget_layout {
~ height = 4 -> 3
~ y = 41 -> 21
# (3 unchanged attributes hidden)
}
# (1 unchanged block hidden)
}
~ widget {
id = 634113401270158
~ widget_layout {
~ height = 7 -> 6
~ y = 45 -> 24
# (3 unchanged attributes hidden)
}
# (1 unchanged block hidden)
}
~ widget {
id = 1156087057165561
~ widget_layout {
~ height = 14 -> 13
~ y = 52 -> 30
# (3 unchanged attributes hidden)
}
# (1 unchanged block hidden)
}
~ widget {
id = 6555130368474596
~ widget_layout {
~ height = 4 -> 3
~ y = 66 -> 43
# (3 unchanged attributes hidden)
}
# (1 unchanged block hidden)
}
~ widget {
id = 8600088985692070
~ widget_layout {
~ height = 7 -> 6
~ y = 70 -> 46
# (3 unchanged attributes hidden)
}
# (1 unchanged block hidden)
}
~ widget {
id = 7189152613059036
~ widget_layout {
~ height = 4 -> 3
~ y = 77 -> 52
# (3 unchanged attributes hidden)
}
# (1 unchanged block hidden)
}
}
# datadog_monitor.DownloadFFISSpreadsheet-failed[0] will be updated in-place
~ resource "datadog_monitor" "DownloadFFISSpreadsheet-failed" {
id = "130337504"
name = "Grants Ingest (Draft - staging): DownloadFFISSpreadsheet failed"
~ query = "sum(last_1h):avg:aws.lambda.errors{env:staging,handlername:downloadffisspreadsheet}.as_count() > 0" -> "sum(last_1h):avg:aws.lambda.errors{env:staging,functionname:grants_ingest-DownloadFFISSpreadsheet}.as_count() > 0"
tags = [
"env:staging",
"service:grants-ingest",
"team:grants",
]
# (16 unchanged attributes hidden)
}
# datadog_monitor.DownloadGrantsGovDB-failed[0] will be updated in-place
~ resource "datadog_monitor" "DownloadGrantsGovDB-failed" {
id = "130337503"
name = "Grants Ingest (Draft - staging): DownloadGrantsGovDB failed"
~ query = "sum(last_10h):sum:aws.lambda.errors{env:staging,handlername:downloadgrantsgovdb}.as_count() / sum:aws.lambda.invocations{env:staging,handlername:downloadgrantsgovdb}.as_count() >= 1.0" -> "sum(last_10h):sum:aws.lambda.errors{env:staging,functionname:grants_ingest-DownloadGrantsGovDB}.as_count() / sum:aws.lambda.invocations{env:staging,functionname:grants_ingest-DownloadGrantsGovDB}.as_count() >= 1.0"
tags = [
"env:staging",
"service:grants-ingest",
"team:grants",
]
# (16 unchanged attributes hidden)
}
# datadog_monitor.EnqueueFFISSpreadsheet-failed[0] will be updated in-place
~ resource "datadog_monitor" "EnqueueFFISSpreadsheet-failed" {
id = "130337493"
name = "Grants Ingest (Draft - staging): EnqueueFFISSpreadsheet failed"
~ query = "sum(last_1h):avg:aws.lambda.errors{env:staging,handlername:enqueueffisspreadsheet}.as_count() > 0" -> "sum(last_1h):avg:aws.lambda.errors{env:staging,functionname:grants_ingest-EnqueueFFISDownload}.as_count() > 0"
tags = [
"env:staging",
"service:grants-ingest",
"team:grants",
]
# (16 unchanged attributes hidden)
}
# datadog_monitor.ExtractGrantsGovXMLToDB-failed[0] will be updated in-place
~ resource "datadog_monitor" "ExtractGrantsGovXMLToDB-failed" {
id = "130337502"
name = "Grants Ingest (Draft - staging): ExtractGrantsGovXMLToDB failed"
~ query = "sum(last_1h):avg:aws.lambda.errors{env:staging,handlername:enqueueffisspreadsheet}.as_count() > 0" -> "sum(last_1h):avg:aws.lambda.errors{env:staging,functionname:grants_ingest-ExtractGrantsGovDBToXML}.as_count() > 0"
tags = [
"env:staging",
"service:grants-ingest",
"team:grants",
]
# (16 unchanged attributes hidden)
}
# datadog_monitor.PersistFFISData-failed[0] will be updated in-place
~ resource "datadog_monitor" "PersistFFISData-failed" {
id = "130337496"
name = "Grants Ingest (Draft - staging): PersistFFISData failed"
~ query = "sum(last_1h):avg:aws.lambda.errors{env:staging,handlername:persistffisdata}.as_count() > 0" -> "sum(last_1h):avg:aws.lambda.errors{env:staging,functionname:grants_ingest-PersistFFISData}.as_count() > 0"
tags = [
"env:staging",
"service:grants-ingest",
"team:grants",
]
# (16 unchanged attributes hidden)
}
# datadog_monitor.PersistGrantsGovXMLDB-failed[0] will be updated in-place
~ resource "datadog_monitor" "PersistGrantsGovXMLDB-failed" {
id = "130337497"
name = "Grants Ingest (Draft - staging): PersistGrantsGovXMLDB failed"
~ query = "sum(last_1h):avg:aws.lambda.errors{env:staging,handlername:persistgrantsgovxmldb}.as_count() > 0" -> "sum(last_1h):avg:aws.lambda.errors{env:staging,functionname:grants_ingest-PersistGrantsGovXMLDB}.as_count() > 0"
tags = [
"env:staging",
"service:grants-ingest",
"team:grants",
]
# (16 unchanged attributes hidden)
}
# datadog_monitor.ReceiveFFISEmail-failed[0] will be updated in-place
~ resource "datadog_monitor" "ReceiveFFISEmail-failed" {
id = "130337498"
name = "Grants Ingest (Draft - staging): ReceiveFFISEmail failed"
~ query = "sum(last_1h):avg:aws.lambda.errors{env:staging,handlername:receiveffisemail}.as_count() > 0" -> "sum(last_1h):avg:aws.lambda.errors{env:staging,functionname:grants_ingest-ReceiveFFISEmail}.as_count() > 0"
tags = [
"env:staging",
"service:grants-ingest",
"team:grants",
]
# (16 unchanged attributes hidden)
}
# datadog_monitor.SplitFFISSpreadsheet-failed[0] will be updated in-place
~ resource "datadog_monitor" "SplitFFISSpreadsheet-failed" {
id = "130337499"
name = "Grants Ingest (Draft - staging): SplitFFISSpreadsheet failed"
~ query = "sum(last_1h):avg:aws.lambda.errors{env:staging,handlername:splitffisspreadsheet}.as_count() > 0" -> "sum(last_1h):avg:aws.lambda.errors{env:staging,handlername:grants_ingest-SplitFFISSpreadsheet}.as_count() > 0"
tags = [
"env:staging",
"service:grants-ingest",
"team:grants",
]
# (16 unchanged attributes hidden)
}
# datadog_monitor.SplitGrantsGovXMLDB-failed[0] will be updated in-place
~ resource "datadog_monitor" "SplitGrantsGovXMLDB-failed" {
id = "130337501"
name = "Grants Ingest (Draft - staging): SplitGrantsGovXMLDB failed"
~ query = "sum(last_1h):avg:aws.lambda.errors{env:staging,handlername:splitgrantsgovxmldb}.as_count() > 0" -> "sum(last_1h):avg:aws.lambda.errors{env:staging,handlername:grants_ingest-ExtractGrantsGovDBToXML}.as_count() > 0"
tags = [
"env:staging",
"service:grants-ingest",
"team:grants",
]
# (16 unchanged attributes hidden)
}
# module.DownloadFFISSpreadsheet.module.lambda_artifact.aws_s3_object.lambda_function must be replaced
-/+ resource "aws_s3_object" "lambda_function" {
~ bucket_key_enabled = false -> (known after apply)
~ content_type = "binary/octet-stream" -> (known after apply)
~ etag = "3bd592e934b24c0eb035b204851316bc-3" -> (known after apply)
~ id = "a68288a400b89601fd9240032ac9f588.zip" -> (known after apply)
~ key = "a68288a400b89601fd9240032ac9f588.zip" -> "faf4133149ac61f650724e9919b0fe50.zip" # forces replacement
+ kms_key_id = (known after apply)
- metadata = {} -> null
~ storage_class = "STANDARD" -> (known after apply)
- tags = {} -> null
~ version_id = "YFxP7sI9ZiKDilgRZq8XAxoNzRk0a5lI" -> (known after apply)
# (5 unchanged attributes hidden)
}
# module.DownloadFFISSpreadsheet.module.lambda_function.aws_lambda_function.this[0] will be updated in-place
~ resource "aws_lambda_function" "this" {
id = "grants_ingest-DownloadFFISSpreadsheet"
~ last_modified = "2023-10-02T22:25:47.000+0000" -> (known after apply)
~ qualified_arn = "arn:aws:lambda:us-west-2:357150818708:function:grants_ingest-DownloadFFISSpreadsheet:23" -> (known after apply)
~ qualified_invoke_arn = "arn:aws:apigateway:us-west-2:lambda:path/2015-03-31/functions/arn:aws:lambda:us-west-2:357150818708:function:grants_ingest-DownloadFFISSpreadsheet:23/invocations" -> (known after apply)
~ s3_key = "a68288a400b89601fd9240032ac9f588.zip" -> "faf4133149ac61f650724e9919b0fe50.zip"
tags = {}
~ version = "23" -> (known after apply)
# (19 unchanged attributes hidden)
~ environment {
~ variables = {
~ "DD_TAGS" = "git.commit.sha:2fa433137a9333ddb458301f1191858f5a0487a8,git.repository_url:github.com/usdigitalresponse/grants-ingest,handlername:downloadffisspreadsheet" -> "git.commit.sha:b458bf2e4926e6d44a07a5675c12c319c582aa6d,git.repository_url:github.com/usdigitalresponse/grants-ingest,handlername:downloadffisspreadsheet"
~ "DD_VERSION" = "2fa433137a9333ddb458301f1191858f5a0487a8" -> "b458bf2e4926e6d44a07a5675c12c319c582aa6d"
# (11 unchanged elements hidden)
}
}
# (3 unchanged blocks hidden)
}
# module.DownloadFFISSpreadsheet.module.lambda_function.aws_lambda_permission.current_version_triggers["SQSQueueNotification"] must be replaced
-/+ resource "aws_lambda_permission" "current_version_triggers" {
~ id = "SQSQueueNotification" -> (known after apply)
~ qualifier = "23" # forces replacement -> (known after apply) # forces replacement
+ statement_id_prefix = (known after apply)
# (4 unchanged attributes hidden)
}
# module.DownloadGrantsGovDB.module.lambda_artifact.aws_s3_object.lambda_function must be replaced
-/+ resource "aws_s3_object" "lambda_function" {
~ bucket_key_enabled = false -> (known after apply)
~ content_type = "binary/octet-stream" -> (known after apply)
~ etag = "03130044f3093dad718aac0c27133593-3" -> (known after apply)
~ id = "e95979c86b17c63e370eca79acffe338.zip" -> (known after apply)
~ key = "e95979c86b17c63e370eca79acffe338.zip" -> "5ddfdd27fc59d457a0a2c41a950bfd56.zip" # forces replacement
+ kms_key_id = (known after apply)
- metadata = {} -> null
~ storage_class = "STANDARD" -> (known after apply)
- tags = {} -> null
~ version_id = "gpCeCx3VFat2Zuvjsz_DO737X21PJUFx" -> (known after apply)
# (5 unchanged attributes hidden)
}
# module.DownloadGrantsGovDB.module.lambda_function.aws_lambda_function.this[0] will be updated in-place
~ resource "aws_lambda_function" "this" {
id = "grants_ingest-DownloadGrantsGovDB"
~ last_modified = "2023-10-02T22:25:47.000+0000" -> (known after apply)
~ qualified_arn = "arn:aws:lambda:us-west-2:357150818708:function:grants_ingest-DownloadGrantsGovDB:23" -> (known after apply)
~ qualified_invoke_arn = "arn:aws:apigateway:us-west-2:lambda:path/2015-03-31/functions/arn:aws:lambda:us-west-2:357150818708:function:grants_ingest-DownloadGrantsGovDB:23/invocations" -> (known after apply)
~ s3_key = "e95979c86b17c63e370eca79acffe338.zip" -> "5ddfdd27fc59d457a0a2c41a950bfd56.zip"
tags = {}
~ version = "23" -> (known after apply)
# (19 unchanged attributes hidden)
~ environment {
~ variables = {
~ "DD_TAGS" = "git.commit.sha:2fa433137a9333ddb458301f1191858f5a0487a8,git.repository_url:github.com/usdigitalresponse/grants-ingest,handlername:downloadgrantsgovdb" -> "git.commit.sha:b458bf2e4926e6d44a07a5675c12c319c582aa6d,git.repository_url:github.com/usdigitalresponse/grants-ingest,handlername:downloadgrantsgovdb"
~ "DD_VERSION" = "2fa433137a9333ddb458301f1191858f5a0487a8" -> "b458bf2e4926e6d44a07a5675c12c319c582aa6d"
# (12 unchanged elements hidden)
}
}
# (3 unchanged blocks hidden)
}
# module.DownloadGrantsGovDB.module.lambda_function.aws_lambda_permission.current_version_triggers["Schedule"] must be replaced
-/+ resource "aws_lambda_permission" "current_version_triggers" {
~ id = "Schedule" -> (known after apply)
~ qualifier = "23" # forces replacement -> (known after apply) # forces replacement
+ statement_id_prefix = (known after apply)
# (5 unchanged attributes hidden)
}
# module.EnqueueFFISDownload.module.lambda_artifact.aws_s3_object.lambda_function must be replaced
-/+ resource "aws_s3_object" "lambda_function" {
~ bucket_key_enabled = false -> (known after apply)
~ content_type = "binary/octet-stream" -> (known after apply)
~ etag = "4bd0a3513d1ee5fab73bca61962967f9-3" -> (known after apply)
~ id = "af6e9484453a23f6e7004a60e3f30f93.zip" -> (known after apply)
~ key = "af6e9484453a23f6e7004a60e3f30f93.zip" -> "8acfe3b24378e8ebeb70110e8282f16c.zip" # forces replacement
+ kms_key_id = (known after apply)
- metadata = {} -> null
~ storage_class = "STANDARD" -> (known after apply)
- tags = {} -> null
~ version_id = ".FUyn6zcqWMU5kFl_P13TFjg8X8VJIXv" -> (known after apply)
# (5 unchanged attributes hidden)
}
# module.EnqueueFFISDownload.module.lambda_function.aws_lambda_function.this[0] will be updated in-place
~ resource "aws_lambda_function" "this" {
id = "grants_ingest-EnqueueFFISDownload"
~ last_modified = "2023-10-02T22:25:47.000+0000" -> (known after apply)
~ qualified_arn = "arn:aws:lambda:us-west-2:357150818708:function:grants_ingest-EnqueueFFISDownload:23" -> (known after apply)
~ qualified_invoke_arn = "arn:aws:apigateway:us-west-2:lambda:path/2015-03-31/functions/arn:aws:lambda:us-west-2:357150818708:function:grants_ingest-EnqueueFFISDownload:23/invocations" -> (known after apply)
~ s3_key = "af6e9484453a23f6e7004a60e3f30f93.zip" -> "8acfe3b24378e8ebeb70110e8282f16c.zip"
tags = {}
~ version = "23" -> (known after apply)
# (19 unchanged attributes hidden)
~ environment {
~ variables = {
~ "DD_TAGS" = "git.commit.sha:2fa433137a9333ddb458301f1191858f5a0487a8,git.repository_url:github.com/usdigitalresponse/grants-ingest,handlername:enqueueffisdownload" -> "git.commit.sha:b458bf2e4926e6d44a07a5675c12c319c582aa6d,git.repository_url:github.com/usdigitalresponse/grants-ingest,handlername:enqueueffisdownload"
~ "DD_VERSION" = "2fa433137a9333ddb458301f1191858f5a0487a8" -> "b458bf2e4926e6d44a07a5675c12c319c582aa6d"
# (11 unchanged elements hidden)
}
}
# (3 unchanged blocks hidden)
}
# module.EnqueueFFISDownload.module.lambda_function.aws_lambda_permission.current_version_triggers["S3BucketNotification"] must be replaced
-/+ resource "aws_lambda_permission" "current_version_triggers" {
~ id = "S3BucketNotification" -> (known after apply)
~ qualifier = "23" # forces replacement -> (known after apply) # forces replacement
+ statement_id_prefix = (known after apply)
# (5 unchanged attributes hidden)
}
# module.ExtractGrantsGovDBToXML.module.lambda_artifact.aws_s3_object.lambda_function must be replaced
-/+ resource "aws_s3_object" "lambda_function" {
~ bucket_key_enabled = false -> (known after apply)
~ content_type = "binary/octet-stream" -> (known after apply)
~ etag = "1dfb10713594f8a32bad444948b66c7c-3" -> (known after apply)
~ id = "2b37f61d9a8146f9940fda43bc4dc235.zip" -> (known after apply)
~ key = "2b37f61d9a8146f9940fda43bc4dc235.zip" -> "1d916c78b7981828c97e2c0876e556af.zip" # forces replacement
+ kms_key_id = (known after apply)
- metadata = {} -> null
~ storage_class = "STANDARD" -> (known after apply)
- tags = {} -> null
~ version_id = "Pr3q1fSRzdqhCKyPaV_Hy23BpHMkd6ro" -> (known after apply)
# (5 unchanged attributes hidden)
}
# module.ExtractGrantsGovDBToXML.module.lambda_function.aws_lambda_function.this[0] will be updated in-place
~ resource "aws_lambda_function" "this" {
id = "grants_ingest-ExtractGrantsGovDBToXML"
~ last_modified = "2023-10-02T22:25:47.000+0000" -> (known after apply)
~ qualified_arn = "arn:aws:lambda:us-west-2:357150818708:function:grants_ingest-ExtractGrantsGovDBToXML:23" -> (known after apply)
~ qualified_invoke_arn = "arn:aws:apigateway:us-west-2:lambda:path/2015-03-31/functions/arn:aws:lambda:us-west-2:357150818708:function:grants_ingest-ExtractGrantsGovDBToXML:23/invocations" -> (known after apply)
~ s3_key = "2b37f61d9a8146f9940fda43bc4dc235.zip" -> "1d916c78b7981828c97e2c0876e556af.zip"
tags = {}
~ version = "23" -> (known after apply)
# (19 unchanged attributes hidden)
~ environment {
~ variables = {
~ "DD_TAGS" = "git.commit.sha:2fa433137a9333ddb458301f1191858f5a0487a8,git.repository_url:github.com/usdigitalresponse/grants-ingest,handlername:extractgrantsgovdbtoxml" -> "git.commit.sha:b458bf2e4926e6d44a07a5675c12c319c582aa6d,git.repository_url:github.com/usdigitalresponse/grants-ingest,handlername:extractgrantsgovdbtoxml"
~ "DD_VERSION" = "2fa433137a9333ddb458301f1191858f5a0487a8" -> "b458bf2e4926e6d44a07a5675c12c319c582aa6d"
# (11 unchanged elements hidden)
}
}
# (3 unchanged blocks hidden)
}
# module.ExtractGrantsGovDBToXML.module.lambda_function.aws_lambda_permission.current_version_triggers["S3BucketNotification"] must be replaced
-/+ resource "aws_lambda_permission" "current_version_triggers" {
~ id = "S3BucketNotification" -> (known after apply)
~ qualifier = "23" # forces replacement -> (known after apply) # forces replacement
+ statement_id_prefix = (known after apply)
# (5 unchanged attributes hidden)
}
# module.PersistFFISData.module.lambda_artifact.aws_s3_object.lambda_function must be replaced
-/+ resource "aws_s3_object" "lambda_function" {
~ bucket_key_enabled = false -> (known after apply)
~ content_type = "binary/octet-stream" -> (known after apply)
~ etag = "401e3242591bc5b7e930660ab992228c-3" -> (known after apply)
~ id = "f3f190fc7a19d73cb139bf34dd2feddd.zip" -> (known after apply)
~ key = "f3f190fc7a19d73cb139bf34dd2feddd.zip" -> "78b6b8d9815149423f88f913d68c65c6.zip" # forces replacement
+ kms_key_id = (known after apply)
- metadata = {} -> null
~ storage_class = "STANDARD" -> (known after apply)
- tags = {} -> null
~ version_id = "XPqYeSMWNTeosLxT3RTf4crLvTPlO0qc" -> (known after apply)
# (5 unchanged attributes hidden)
}
# module.PersistFFISData.module.lambda_function.aws_lambda_function.this[0] will be updated in-place
~ resource "aws_lambda_function" "this" {
id = "grants_ingest-PersistFFISData"
~ last_modified = "2023-10-02T22:25:47.000+0000" -> (known after apply)
~ qualified_arn = "arn:aws:lambda:us-west-2:357150818708:function:grants_ingest-PersistFFISData:23" -> (known after apply)
~ qualified_invoke_arn = "arn:aws:apigateway:us-west-2:lambda:path/2015-03-31/functions/arn:aws:lambda:us-west-2:357150818708:function:grants_ingest-PersistFFISData:23/invocations" -> (known after apply)
~ s3_key = "f3f190fc7a19d73cb139bf34dd2feddd.zip" -> "78b6b8d9815149423f88f913d68c65c6.zip"
tags = {}
~ version = "23" -> (known after apply)
# (19 unchanged attributes hidden)
~ environment {
~ variables = {
~ "DD_TAGS" = "git.commit.sha:2fa433137a9333ddb458301f1191858f5a0487a8,git.repository_url:github.com/usdigitalresponse/grants-ingest,handlername:persistffisdata" -> "git.commit.sha:b458bf2e4926e6d44a07a5675c12c319c582aa6d,git.repository_url:github.com/usdigitalresponse/grants-ingest,handlername:persistffisdata"
~ "DD_VERSION" = "2fa433137a9333ddb458301f1191858f5a0487a8" -> "b458bf2e4926e6d44a07a5675c12c319c582aa6d"
# (11 unchanged elements hidden)
}
}
# (3 unchanged blocks hidden)
}
# module.PersistFFISData.module.lambda_function.aws_lambda_permission.current_version_triggers["S3BucketNotification"] must be replaced
-/+ resource "aws_lambda_permission" "current_version_triggers" {
~ id = "S3BucketNotification" -> (known after apply)
~ qualifier = "23" # forces replacement -> (known after apply) # forces replacement
+ statement_id_prefix = (known after apply)
# (5 unchanged attributes hidden)
}
# module.PersistGrantsGovXMLDB.module.lambda_artifact.aws_s3_object.lambda_function must be replaced
-/+ resource "aws_s3_object" "lambda_function" {
~ bucket_key_enabled = false -> (known after apply)
~ content_type = "binary/octet-stream" -> (known after apply)
~ etag = "a3bac7b60454c7e3f9db1db1c427a1b5-3" -> (known after apply)
~ id = "f3466d732ef128366f65fe86e4c4d199.zip" -> (known after apply)
~ key = "f3466d732ef128366f65fe86e4c4d199.zip" -> "1d58d46f6a50884f257f30d55abd3dc6.zip" # forces replacement
+ kms_key_id = (known after apply)
- metadata = {} -> null
~ storage_class = "STANDARD" -> (known after apply)
- tags = {} -> null
~ version_id = "WtYAVQJavScAn16B.Txvimmja_oDLsgA" -> (known after apply)
# (5 unchanged attributes hidden)
}
# module.PersistGrantsGovXMLDB.module.lambda_function.aws_lambda_function.this[0] will be updated in-place
~ resource "aws_lambda_function" "this" {
id = "grants_ingest-PersistGrantsGovXMLDB"
~ last_modified = "2023-10-02T22:25:47.000+0000" -> (known after apply)
~ qualified_arn = "arn:aws:lambda:us-west-2:357150818708:function:grants_ingest-PersistGrantsGovXMLDB:23" -> (known after apply)
~ qualified_invoke_arn = "arn:aws:apigateway:us-west-2:lambda:path/2015-03-31/functions/arn:aws:lambda:us-west-2:357150818708:function:grants_ingest-PersistGrantsGovXMLDB:23/invocations" -> (known after apply)
~ s3_key = "f3466d732ef128366f65fe86e4c4d199.zip" -> "1d58d46f6a50884f257f30d55abd3dc6.zip"
tags = {}
~ version = "23" -> (known after apply)
# (19 unchanged attributes hidden)
~ environment {
~ variables = {
~ "DD_TAGS" = "git.commit.sha:2fa433137a9333ddb458301f1191858f5a0487a8,git.repository_url:github.com/usdigitalresponse/grants-ingest,handlername:persistgrantsgovxmldb" -> "git.commit.sha:b458bf2e4926e6d44a07a5675c12c319c582aa6d,git.repository_url:github.com/usdigitalresponse/grants-ingest,handlername:persistgrantsgovxmldb"
~ "DD_VERSION" = "2fa433137a9333ddb458301f1191858f5a0487a8" -> "b458bf2e4926e6d44a07a5675c12c319c582aa6d"
# (11 unchanged elements hidden)
}
}
# (3 unchanged blocks hidden)
}
# module.PersistGrantsGovXMLDB.module.lambda_function.aws_lambda_permission.current_version_triggers["S3BucketNotification"] must be replaced
-/+ resource "aws_lambda_permission" "current_version_triggers" {
~ id = "S3BucketNotification" -> (known after apply)
~ qualifier = "23" # forces replacement -> (known after apply) # forces replacement
+ statement_id_prefix = (known after apply)
# (5 unchanged attributes hidden)
}
# module.PublishGrantEvents.module.lambda_artifact.aws_s3_object.lambda_function must be replaced
-/+ resource "aws_s3_object" "lambda_function" {
~ bucket_key_enabled = false -> (known after apply)
~ content_type = "binary/octet-stream" -> (known after apply)
~ etag = "657ebb808fc47a6a65a7dd753a8b30d7-3" -> (known after apply)
~ id = "b89c18811b5d08fd93fa7da86271e0a2.zip" -> (known after apply)
~ key = "b89c18811b5d08fd93fa7da86271e0a2.zip" -> "6dc4455b51c1b95e60a784e1ea51e49c.zip" # forces replacement
+ kms_key_id = (known after apply)
- metadata = {} -> null
~ storage_class = "STANDARD" -> (known after apply)
- tags = {} -> null
~ version_id = "jJjqIRZ2Qlt0YAXh741nnETtdWk2_Ee2" -> (known after apply)
# (5 unchanged attributes hidden)
}
# module.PublishGrantEvents.module.lambda_function.aws_lambda_function.this[0] will be updated in-place
~ resource "aws_lambda_function" "this" {
id = "grants_ingest-PublishGrantEvents"
~ last_modified = "2023-10-02T22:25:47.000+0000" -> (known after apply)
~ qualified_arn = "arn:aws:lambda:us-west-2:357150818708:function:grants_ingest-PublishGrantEvents:24" -> (known after apply)
~ qualified_invoke_arn = "arn:aws:apigateway:us-west-2:lambda:path/2015-03-31/functions/arn:aws:lambda:us-west-2:357150818708:function:grants_ingest-PublishGrantEvents:24/invocations" -> (known after apply)
~ s3_key = "b89c18811b5d08fd93fa7da86271e0a2.zip" -> "6dc4455b51c1b95e60a784e1ea51e49c.zip"
tags = {}
~ version = "24" -> (known after apply)
# (19 unchanged attributes hidden)
~ environment {
~ variables = {
~ "DD_TAGS" = "git.commit.sha:2fa433137a9333ddb458301f1191858f5a0487a8,git.repository_url:github.com/usdigitalresponse/grants-ingest,handlername:publishgrantevents" -> "git.commit.sha:b458bf2e4926e6d44a07a5675c12c319c582aa6d,git.repository_url:github.com/usdigitalresponse/grants-ingest,handlername:publishgrantevents"
~ "DD_VERSION" = "2fa433137a9333ddb458301f1191858f5a0487a8" -> "b458bf2e4926e6d44a07a5675c12c319c582aa6d"
# (11 unchanged elements hidden)
}
}
# (3 unchanged blocks hidden)
}
# module.PublishGrantEvents.module.lambda_function.aws_lambda_permission.current_version_triggers["dynamodb"] must be replaced
-/+ resource "aws_lambda_permission" "current_version_triggers" {
~ id = "dynamodb" -> (known after apply)
~ qualifier = "24" # forces replacement -> (known after apply) # forces replacement
+ statement_id_prefix = (known after apply)
# (5 unchanged attributes hidden)
}
# module.ReceiveFFISEmail.module.lambda_artifact.aws_s3_object.lambda_function must be replaced
-/+ resource "aws_s3_object" "lambda_function" {
~ bucket_key_enabled = false -> (known after apply)
~ content_type = "binary/octet-stream" -> (known after apply)
~ etag = "28844cb4bbb92d9de9507e0b4f81ac09-3" -> (known after apply)
~ id = "2a25808ce1dba8852f90a127e8b9ac8f.zip" -> (known after apply)
~ key = "2a25808ce1dba8852f90a127e8b9ac8f.zip" -> "92e23db52dd9170f064cf463de497e32.zip" # forces replacement
+ kms_key_id = (known after apply)
- metadata = {} -> null
~ storage_class = "STANDARD" -> (known after apply)
- tags = {} -> null
~ version_id = "yKQ2_eISiWpRTmJ3oCHcLGKLMsJG3PC_" -> (known after apply)
# (5 unchanged attributes hidden)
}
# module.ReceiveFFISEmail.module.lambda_function.aws_lambda_function.this[0] will be updated in-place
~ resource "aws_lambda_function" "this" {
id = "grants_ingest-ReceiveFFISEmail"
~ last_modified = "2023-10-02T22:25:47.000+0000" -> (known after apply)
~ qualified_arn = "arn:aws:lambda:us-west-2:357150818708:function:grants_ingest-ReceiveFFISEmail:22" -> (known after apply)
~ qualified_invoke_arn = "arn:aws:apigateway:us-west-2:lambda:path/2015-03-31/functions/arn:aws:lambda:us-west-2:357150818708:function:grants_ingest-ReceiveFFISEmail:22/invocations" -> (known after apply)
~ s3_key = "2a25808ce1dba8852f90a127e8b9ac8f.zip" -> "92e23db52dd9170f064cf463de497e32.zip"
tags = {}
~ version = "22" -> (known after apply)
# (19 unchanged attributes hidden)
~ environment {
~ variables = {
~ "DD_TAGS" = "git.commit.sha:2fa433137a9333ddb458301f1191858f5a0487a8,git.repository_url:github.com/usdigitalresponse/grants-ingest,handlername:receiveffisemail" -> "git.commit.sha:b458bf2e4926e6d44a07a5675c12c319c582aa6d,git.repository_url:github.com/usdigitalresponse/grants-ingest,handlername:receiveffisemail"
~ "DD_VERSION" = "2fa433137a9333ddb458301f1191858f5a0487a8" -> "b458bf2e4926e6d44a07a5675c12c319c582aa6d"
# (12 unchanged elements hidden)
}
}
# (3 unchanged blocks hidden)
}
# module.ReceiveFFISEmail.module.lambda_function.aws_lambda_permission.current_version_triggers["S3BucketNotification"] must be replaced
-/+ resource "aws_lambda_permission" "current_version_triggers" {
~ id = "S3BucketNotification" -> (known after apply)
~ qualifier = "22" # forces replacement -> (known after apply) # forces replacement
+ statement_id_prefix = (known after apply)
# (5 unchanged attributes hidden)
}
# module.SplitFFISSpreadsheet.module.lambda_artifact.aws_s3_object.lambda_function must be replaced
-/+ resource "aws_s3_object" "lambda_function" {
~ bucket_key_enabled = false -> (known after apply)
~ content_type = "binary/octet-stream" -> (known after apply)
~ etag = "d39fb21458a7a533cb178dc45d8f8fb2-3" -> (known after apply)
~ id = "d23041aef138dbe2c78bc2ffa5788f7c.zip" -> (known after apply)
~ key = "d23041aef138dbe2c78bc2ffa5788f7c.zip" -> "05002741bc8344e806def1f250b5ccb6.zip" # forces replacement
+ kms_key_id = (known after apply)
- metadata = {} -> null
~ storage_class = "STANDARD" -> (known after apply)
- tags = {} -> null
~ version_id = "P2I7PexgdAzdd_6lfnNyQPBMtlI72zXc" -> (known after apply)
# (5 unchanged attributes hidden)
}
# module.SplitFFISSpreadsheet.module.lambda_function.aws_lambda_function.this[0] will be updated in-place
~ resource "aws_lambda_function" "this" {
id = "grants_ingest-SplitFFISSpreadsheet"
~ last_modified = "2023-10-02T22:25:47.000+0000" -> (known after apply)
~ qualified_arn = "arn:aws:lambda:us-west-2:357150818708:function:grants_ingest-SplitFFISSpreadsheet:23" -> (known after apply)
~ qualified_invoke_arn = "arn:aws:apigateway:us-west-2:lambda:path/2015-03-31/functions/arn:aws:lambda:us-west-2:357150818708:function:grants_ingest-SplitFFISSpreadsheet:23/invocations" -> (known after apply)
~ s3_key = "d23041aef138dbe2c78bc2ffa5788f7c.zip" -> "05002741bc8344e806def1f250b5ccb6.zip"
tags = {}
~ version = "23" -> (known after apply)
# (19 unchanged attributes hidden)
~ environment {
~ variables = {
~ "DD_TAGS" = "git.commit.sha:2fa433137a9333ddb458301f1191858f5a0487a8,git.repository_url:github.com/usdigitalresponse/grants-ingest,handlername:splitffisspreadsheet" -> "git.commit.sha:b458bf2e4926e6d44a07a5675c12c319c582aa6d,git.repository_url:github.com/usdigitalresponse/grants-ingest,handlername:splitffisspreadsheet"
~ "DD_VERSION" = "2fa433137a9333ddb458301f1191858f5a0487a8" -> "b458bf2e4926e6d44a07a5675c12c319c582aa6d"
# (14 unchanged elements hidden)
}
}
# (3 unchanged blocks hidden)
}
# module.SplitFFISSpreadsheet.module.lambda_function.aws_lambda_permission.current_version_triggers["S3BucketNotification"] must be replaced
-/+ resource "aws_lambda_permission" "current_version_triggers" {
~ id = "S3BucketNotification" -> (known after apply)
~ qualifier = "23" # forces replacement -> (known after apply) # forces replacement
+ statement_id_prefix = (known after apply)
# (5 unchanged attributes hidden)
}
# module.SplitGrantsGovXMLDB.module.lambda_artifact.aws_s3_object.lambda_function must be replaced
-/+ resource "aws_s3_object" "lambda_function" {
~ bucket_key_enabled = false -> (known after apply)
~ content_type = "binary/octet-stream" -> (known after apply)
~ etag = "830028c037d41ef822d1404edddae393-3" -> (known after apply)
~ id = "85558ae7c9968741885300412cfb25b0.zip" -> (known after apply)
~ key = "85558ae7c9968741885300412cfb25b0.zip" -> "6aa802f14e52bdf9b855d085064c92d5.zip" # forces replacement
+ kms_key_id = (known after apply)
- metadata = {} -> null
~ storage_class = "STANDARD" -> (known after apply)
- tags = {} -> null
~ version_id = "JNTye_i9KfpPsU6v1E3QJzzNQow57X0e" -> (known after apply)
# (5 unchanged attributes hidden)
}
# module.SplitGrantsGovXMLDB.module.lambda_function.aws_lambda_function.this[0] will be updated in-place
~ resource "aws_lambda_function" "this" {
id = "grants_ingest-SplitGrantsGovXMLDB"
~ last_modified = "2023-10-02T22:25:47.000+0000" -> (known after apply)
~ qualified_arn = "arn:aws:lambda:us-west-2:357150818708:function:grants_ingest-SplitGrantsGovXMLDB:23" -> (known after apply)
~ qualified_invoke_arn = "arn:aws:apigateway:us-west-2:lambda:path/2015-03-31/functions/arn:aws:lambda:us-west-2:357150818708:function:grants_ingest-SplitGrantsGovXMLDB:23/invocations" -> (known after apply)
~ s3_key = "85558ae7c9968741885300412cfb25b0.zip" -> "6aa802f14e52bdf9b855d085064c92d5.zip"
tags = {}
~ version = "23" -> (known after apply)
# (19 unchanged attributes hidden)
~ environment {
~ variables = {
~ "DD_TAGS" = "git.commit.sha:2fa433137a9333ddb458301f1191858f5a0487a8,git.repository_url:github.com/usdigitalresponse/grants-ingest,handlername:splitgrantsgovxmldb" -> "git.commit.sha:b458bf2e4926e6d44a07a5675c12c319c582aa6d,git.repository_url:github.com/usdigitalresponse/grants-ingest,handlername:splitgrantsgovxmldb"
~ "DD_VERSION" = "2fa433137a9333ddb458301f1191858f5a0487a8" -> "b458bf2e4926e6d44a07a5675c12c319c582aa6d"
# (14 unchanged elements hidden)
}
}
# (3 unchanged blocks hidden)
}
# module.SplitGrantsGovXMLDB.module.lambda_function.aws_lambda_permission.current_version_triggers["S3BucketNotification"] must be replaced
-/+ resource "aws_lambda_permission" "current_version_triggers" {
~ id = "S3BucketNotification" -> (known after apply)
~ qualifier = "23" # forces replacement -> (known after apply) # forces replacement
+ statement_id_prefix = (known after apply)
# (5 unchanged attributes hidden)
}
Plan: 20 to add, 20 to change, 20 to destroy. Pusher: @TylerHendrickson, Action: |
as1729
approved these changes
Oct 12, 2023
TylerHendrickson
deleted the
feat/use-functionname-tag-for-monitor-queries
branch
October 12, 2023 18:32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
query
input for Datadog monitors so that they use thefunctionname
tag to target a specific Lambda function instead of using thehandlername
tag with a literal (hard-coded) value. In doing so, this resolves an issue where the query for one of our monitors was configured to target a nonexistenthandlername
value. By usingfunctionname
, we can interpolate an existing value instead of needing to worry about typos (as in the case of the misconfigured monitor) from typing outfunctionname
values, which are not available for interpolation in this context.Additionally, this PR changes the convention for specifying query filters to make use of Terraform's
join()
function, which hopefully improves readability of monitors'query
input values.Testing
Observe that
terraform plan
output reflects that monitors are correctly targetingfunctionname
tags.Manual tests for Reviewer
Checklist