Fix #2760: Path params trailing slash #3065
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @sam-briggs-depop can you please provide the correct link to the issue? Edit: No worries I got it. It's #2760. |
|
Oh drat. Sorry. got my numbers mixed up 😓 |
sam-briggs-depop
force-pushed
the
bugfix/2670-path-params-trailing-slash
branch
from
c080f62
to
3bd9432
Compare
sam-briggs-depop
changed the title
As reported in usebruno#2670, if a URL has a trailing slash and also contains path parameters then the original logic had a bug that would drop the trailing slash. This implements the fix proposed by @ThenTech.
sam-briggs-depop
force-pushed
the
bugfix/2670-path-params-trailing-slash
branch
from
3bd9432
to
05cf069
Compare
|
Ok. The references should be fixed now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #2760, if a URL has a trailing slash and also contains
path parameters then the original logic had a bug that would drop the
trailing slash.
This implements the fix proposed by @ThenTech.
Description
Contribution Checklist:
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.