fix: multipart/form-data body interpolation #3142
Conversation
|
@Its-treason Can you review this if you have some time over the weekend? |
| @@ -195,6 +181,14 @@ const runSingleRequest = async function ( | |||
| request.data = qs.stringify(request.data); | |||
| } | |||
|
|
|||
| if (request?.headers?.['content-type'] === 'multipart/form-data') { | |||
There was a problem hiding this comment.
These two if-statements can be merged.
| // reference: https://github.com/axios/axios/issues/1006#issuecomment-320165427 | ||
| const form = new FormData(); | ||
| forOwn(datas, (value, key) => { | ||
| if (typeof value == 'object') { |
There was a problem hiding this comment.
I would personally invert the if to: typeof value === 'string' and return after form.append like this:
if (typeof data === 'string') {
form.append(key, value);
return;
}
// Code for file here.To make the code more readable
There was a problem hiding this comment.
makes sense, will update the logic
| @@ -15,7 +15,7 @@ | |||
| "bypassProxy": "" | |||
| }, | |||
| "scripts": { | |||
| "moduleWhitelist": ["crypto", "buffer"], | |||
| "moduleWhitelist": ["crypto", "buffer", "form-data"], | |||
There was a problem hiding this comment.
We could add form-data to the default libraries.
There was a problem hiding this comment.
since form-data dep needs to be added to both vm2 and quickjs, i'l create a seperate pr for just that
|
Merged. Thanks @lohxt1 for working on this! |
changes:
~ the
formData bodywill be available in json format during the pre-request script (req.getBody()).json bodyis interpolated after the pre-request step, and theformData bodyis then constructed from the json data.~ if a constructed
formData bodyis directly set in the pre-request script, the interpolation and the construction offormData bodyare skipped.