Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(website): CAN-466 safeInputAddress #1410

Merged
merged 10 commits into from
Oct 8, 2024
Merged

fix(website): CAN-466 safeInputAddress #1410

merged 10 commits into from
Oct 8, 2024

Conversation

nicosampler
Copy link
Contributor

Fixes the safeInputAddress interaction.

Fixes the safeInputAddress interaction.
@nicosampler nicosampler self-assigned this Sep 24, 2024
Copy link

changeset-bot bot commented Sep 24, 2024

⚠️ No Changeset found

Latest commit: 6e63fb9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nicosampler nicosampler requested a review from a team September 24, 2024 12:23
@mjlescano
Copy link
Member

It appears that is breaking:

  1. The X that is used for unselecting the currently selected item
  2. The deletion from the dropdown of the currently selected item
Screen.Recording.2024-09-24.at.10.33.54.mov

Copy link
Member

@mjlescano mjlescano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is throwing an error when arriving to a custom chain url, e.g.:

http://localhost:3000/deploy?chainId=2192&address=0xF5d66dC9B6963c61D7dacB1208145397cAc2e678

Screenshot 2024-10-04 at 10 10 36

and it is working on production with the same url:
image

@mjlescano
Copy link
Member

Moving to approved, as I was missing the custom chain rpc setting.

@nicosampler nicosampler changed the title fix(website): CAN-466 fix(website): CAN-466 safeInputAddress Oct 4, 2024
@nicosampler nicosampler merged commit 80a76ed into dev Oct 8, 2024
9 of 10 checks passed
@nicosampler nicosampler deleted the fix/CAN-466 branch October 8, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants