feat(router): CAN-596 add web-solc to compile on browser #1481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mjlescano
commented
Oct 19, 2024
| @@ -111,16 +111,18 @@ const routerStep = { | |||
| throw new Error(`contract not found: ${n}`); | |||
| } | |||
|
|
|||
| const contractName = n.replace('.', '_'); // Use step name, and replace '.' in case is pointing to an import. | |||
There was a problem hiding this comment.
This fixes a bug where it was not possible to render a Router that included contracts from an imported package 🐛
mjlescano
commented
Oct 19, 2024
saeta-eth
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://linear.app/usecannon/issue/CAN-596/allow-to-build-the-router-on-website-using-solc