Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ribbon to <monochrome /> icon #483

Merged
merged 2 commits into from
Aug 7, 2023
Merged

Conversation

mateuszkwiecinski
Copy link
Member

#482

I haven't figured out a way how AGP transforms monochrome icons yet so it doesn't fix the linked issue, but this PR makes the plugin recognize custom icon resource passed via <monochrome /> tag

@codecov
Copy link

codecov bot commented Aug 6, 2023

Codecov Report

Merging #483 (db9cf3d) into master (acd2848) will increase coverage by 0.01%.
The diff coverage is 86.66%.

@@             Coverage Diff              @@
##             master     #483      +/-   ##
============================================
+ Coverage     80.82%   80.84%   +0.01%     
  Complexity      114      114              
============================================
  Files            16       16              
  Lines           631      642      +11     
  Branches        100      102       +2     
============================================
+ Hits            510      519       +9     
  Misses           49       49              
- Partials         72       74       +2     
Files Changed Coverage Δ
.../starter/easylauncher/plugin/EasyLauncherPlugin.kt 67.02% <50.00%> (-0.73%) ⬇️
...ct/starter/easylauncher/plugin/EasyLauncherTask.kt 75.92% <75.00%> (-1.00%) ⬇️
...m/project/starter/easylauncher/plugin/XmlReader.kt 75.00% <100.00%> (+3.00%) ⬆️
...ect/starter/easylauncher/plugin/models/IconFile.kt 100.00% <100.00%> (ø)

@mateuszkwiecinski mateuszkwiecinski marked this pull request as ready for review August 7, 2023 21:21
@mateuszkwiecinski mateuszkwiecinski merged commit b9781ed into master Aug 7, 2023
21 checks passed
@mateuszkwiecinski mateuszkwiecinski deleted the monochrome_launcher branch August 7, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant