-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix isolated projects compatibility #263
Conversation
Diffuse output:
JAR
CLASSES
|
val recognisedEditorConfigs = generateSequence(projectDir) { if (it == rootProject.projectDir) null else it.parentFile } | ||
.map { it.resolve(".editorconfig") } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this will now traverse directories and not projects. Previously if projects were set up with custom directories, the plugin would look for the .editorconfig
file in the actual project directories. Now it traverses the file system directories from the project directory up to the root project directory.
So e.g. for projects set up to use custom directories (using project(":some-project").projectDir = file("custom/directory")
)
: -> .
:foo -> ./projects/custom/directory/foo
:foo:bar -> ./projects/custom/directory/bar
then when applying the plugin in :foo:bar
project:
- previously we'd search for
.editorconfig
files in./projects/custom/directory/foo
,./projects/(...)/bar
and.
- now, we'll search for
.editorconfig
files in./projects/custom/directory/bar
,./projects/custom/directory
,./projects/custom
,./projects/
and.
(fwiw I think the new behavior is more intuitive and expected)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- this supposed to resemble what ktlint does when searching for applicable editorconfigs, so the new behavior can be even considered a fix 👍
No description provided.