Prioritise authentication with user credentials over refresh token if both are sent. #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sun
requested changes
Sep 11, 2024
sun
changed the title
Co-authored-by: Daniel Kudwien <[email protected]>
Co-authored-by: Daniel Kudwien <[email protected]>
Co-authored-by: Daniel Kudwien <[email protected]>
sun
requested changes
Sep 21, 2024
Co-authored-by: Daniel Kudwien <[email protected]>
sun
approved these changes
Sep 24, 2024
Co-authored-by: Daniel Kudwien <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing the issue reported here:
I also added some checks so that we can handle cases where a username is provided and no password or vice versa so that we don't log someone in based on a refresh token purely because an invalid request has been made.