Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-write components without styled-components #1043

Merged
merged 4 commits into from
Oct 13, 2023
Merged

re-write components without styled-components #1043

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b6dafe2
update Flex to use CSS modules
jasonbasuil Oct 12, 2023
13c61b9
update PopoverCard to use CSS Modules
jasonbasuil Oct 12, 2023
31f201d
remove styled-components
jasonbasuil Oct 12, 2023
ae249a3
fix container style
jasonbasuil Oct 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,7 @@
"react-dom": "^16.12.0",
"react-modal": "^3.12.1",
"react-popper": "^2.2.3",
"react-tracking": "^8.1.0",
"styled-components": "^5.3.3"
"react-tracking": "^8.1.0"
},
"devDependencies": {
"@babel/cli": "^7.8.4",
Expand Down Expand Up @@ -150,7 +149,6 @@
"storybook": "7.4.1",
"storybook-addon-designs": "6.3.1",
"style-loader": "^1.1.3",
"styled-components": "^5.3.3",
"typescript": "^4.9.5",
"webpack": "^5.80.0",
"yalc": "^1.0.0-pre.53"
Expand All @@ -161,8 +159,7 @@
"jackspeak": "2.1.1",
"make-dir": "4.0.0",
"normalize-package-data": "^3.0.0",
"semver": "^7.5.3",
"styled-components": "^5"
"semver": "^7.5.3"
},
"description": "UI Storybook design system",
"files": [
Expand Down
224 changes: 208 additions & 16 deletions spec/__snapshots__/Storyshots.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13519,7 +13519,19 @@ exports[`Storyshots Components/Table Default 1`] = `
exports[`Storyshots Components/Table Loading Custom Columns 1`] = `
Array [
<div
className="sc-aXZVg fbaeUV TableLoadingSkeleton"
className="Flex TableLoadingSkeleton"
style={
Object {
"flex": undefined,
"flexBasis": undefined,
"flexGrow": undefined,
"flexShrink": undefined,
"height": undefined,
"maxHeight": undefined,
"maxWidth": undefined,
"width": undefined,
}
}
>
<span
aria-busy={true}
Expand Down Expand Up @@ -13613,7 +13625,19 @@ Array [
</span>
</div>,
<div
className="sc-aXZVg fbaeUV TableLoadingSkeleton"
className="Flex TableLoadingSkeleton"
style={
Object {
"flex": undefined,
"flexBasis": undefined,
"flexGrow": undefined,
"flexShrink": undefined,
"height": undefined,
"maxHeight": undefined,
"maxWidth": undefined,
"width": undefined,
}
}
>
<span
aria-busy={true}
Expand Down Expand Up @@ -13707,7 +13731,19 @@ Array [
</span>
</div>,
<div
className="sc-aXZVg fbaeUV TableLoadingSkeleton"
className="Flex TableLoadingSkeleton"
style={
Object {
"flex": undefined,
"flexBasis": undefined,
"flexGrow": undefined,
"flexShrink": undefined,
"height": undefined,
"maxHeight": undefined,
"maxWidth": undefined,
"width": undefined,
}
}
>
<span
aria-busy={true}
Expand Down Expand Up @@ -13801,7 +13837,19 @@ Array [
</span>
</div>,
<div
className="sc-aXZVg fbaeUV TableLoadingSkeleton"
className="Flex TableLoadingSkeleton"
style={
Object {
"flex": undefined,
"flexBasis": undefined,
"flexGrow": undefined,
"flexShrink": undefined,
"height": undefined,
"maxHeight": undefined,
"maxWidth": undefined,
"width": undefined,
}
}
>
<span
aria-busy={true}
Expand Down Expand Up @@ -13900,7 +13948,19 @@ Array [
exports[`Storyshots Components/Table Loading Default 1`] = `
Array [
<div
className="sc-aXZVg fbaeUV TableLoadingSkeleton"
className="Flex TableLoadingSkeleton"
style={
Object {
"flex": undefined,
"flexBasis": undefined,
"flexGrow": undefined,
"flexShrink": undefined,
"height": undefined,
"maxHeight": undefined,
"maxWidth": undefined,
"width": undefined,
}
}
>
<span
aria-busy={true}
Expand Down Expand Up @@ -14030,7 +14090,19 @@ Array [
</span>
</div>,
<div
className="sc-aXZVg fbaeUV TableLoadingSkeleton"
className="Flex TableLoadingSkeleton"
style={
Object {
"flex": undefined,
"flexBasis": undefined,
"flexGrow": undefined,
"flexShrink": undefined,
"height": undefined,
"maxHeight": undefined,
"maxWidth": undefined,
"width": undefined,
}
}
>
<span
aria-busy={true}
Expand Down Expand Up @@ -14160,7 +14232,19 @@ Array [
</span>
</div>,
<div
className="sc-aXZVg fbaeUV TableLoadingSkeleton"
className="Flex TableLoadingSkeleton"
style={
Object {
"flex": undefined,
"flexBasis": undefined,
"flexGrow": undefined,
"flexShrink": undefined,
"height": undefined,
"maxHeight": undefined,
"maxWidth": undefined,
"width": undefined,
}
}
>
<span
aria-busy={true}
Expand Down Expand Up @@ -14290,7 +14374,19 @@ Array [
</span>
</div>,
<div
className="sc-aXZVg fbaeUV TableLoadingSkeleton"
className="Flex TableLoadingSkeleton"
style={
Object {
"flex": undefined,
"flexBasis": undefined,
"flexGrow": undefined,
"flexShrink": undefined,
"height": undefined,
"maxHeight": undefined,
"maxWidth": undefined,
"width": undefined,
}
}
>
<span
aria-busy={true}
Expand Down Expand Up @@ -14420,7 +14516,19 @@ Array [
</span>
</div>,
<div
className="sc-aXZVg fbaeUV TableLoadingSkeleton"
className="Flex TableLoadingSkeleton"
style={
Object {
"flex": undefined,
"flexBasis": undefined,
"flexGrow": undefined,
"flexShrink": undefined,
"height": undefined,
"maxHeight": undefined,
"maxWidth": undefined,
"width": undefined,
}
}
>
<span
aria-busy={true}
Expand Down Expand Up @@ -14550,7 +14658,19 @@ Array [
</span>
</div>,
<div
className="sc-aXZVg fbaeUV TableLoadingSkeleton"
className="Flex TableLoadingSkeleton"
style={
Object {
"flex": undefined,
"flexBasis": undefined,
"flexGrow": undefined,
"flexShrink": undefined,
"height": undefined,
"maxHeight": undefined,
"maxWidth": undefined,
"width": undefined,
}
}
>
<span
aria-busy={true}
Expand Down Expand Up @@ -14680,7 +14800,19 @@ Array [
</span>
</div>,
<div
className="sc-aXZVg fbaeUV TableLoadingSkeleton"
className="Flex TableLoadingSkeleton"
style={
Object {
"flex": undefined,
"flexBasis": undefined,
"flexGrow": undefined,
"flexShrink": undefined,
"height": undefined,
"maxHeight": undefined,
"maxWidth": undefined,
"width": undefined,
}
}
>
<span
aria-busy={true}
Expand Down Expand Up @@ -29236,7 +29368,19 @@ Array [

exports[`Storyshots Layouts/CardStack Centered 1`] = `
<div
className="sc-aXZVg eEvRmZ"
className="Flex"
style={
Object {
"flex": undefined,
"flexBasis": undefined,
"flexGrow": undefined,
"flexShrink": undefined,
"height": undefined,
"maxHeight": undefined,
"maxWidth": undefined,
"width": undefined,
}
}
>
<div
className="CardStack CardStack--sm"
Expand Down Expand Up @@ -30157,7 +30301,19 @@ exports[`Storyshots Layouts/Container Setting One Column Width 1`] = `

exports[`Storyshots Layouts/Flex Align Items 1`] = `
<div
className="sc-aXZVg idOQCp"
className="Flex"
style={
Object {
"flex": undefined,
"flexBasis": undefined,
"flexGrow": undefined,
"flexShrink": undefined,
"height": undefined,
"maxHeight": undefined,
"maxWidth": undefined,
"width": undefined,
}
}
>
<section
className="Card Card--xs"
Expand Down Expand Up @@ -30208,7 +30364,19 @@ exports[`Storyshots Layouts/Flex Align Items 1`] = `

exports[`Storyshots Layouts/Flex Default 1`] = `
<div
className="sc-aXZVg fBLyyp"
className="Flex"
style={
Object {
"flex": undefined,
"flexBasis": undefined,
"flexGrow": undefined,
"flexShrink": undefined,
"height": undefined,
"maxHeight": undefined,
"maxWidth": undefined,
"width": undefined,
}
}
>
<section
className="Card Card--xs"
Expand Down Expand Up @@ -30254,7 +30422,19 @@ exports[`Storyshots Layouts/Flex Default 1`] = `

exports[`Storyshots Layouts/Flex Flex Direction 1`] = `
<div
className="sc-aXZVg cfPfql"
className="Flex"
style={
Object {
"flex": undefined,
"flexBasis": undefined,
"flexGrow": undefined,
"flexShrink": undefined,
"height": undefined,
"maxHeight": undefined,
"maxWidth": undefined,
"width": undefined,
}
}
>
<section
className="Card Card--xs"
Expand Down Expand Up @@ -30305,7 +30485,19 @@ exports[`Storyshots Layouts/Flex Flex Direction 1`] = `

exports[`Storyshots Layouts/Flex Justify Content 1`] = `
<div
className="sc-aXZVg fBLyyp"
className="Flex"
style={
Object {
"flex": undefined,
"flexBasis": undefined,
"flexGrow": undefined,
"flexShrink": undefined,
"height": undefined,
"maxHeight": undefined,
"maxWidth": undefined,
"width": undefined,
}
}
>
<section
className="Card Card--xs"
Expand Down
Loading
Loading