TDW: upgrade packages, remove unnecessary resolutions #1300
Conversation
| @@ -178,14 +178,14 @@ function DateTimePicker({ | |||
| adjustDateOnChange | |||
| allowSameDay | |||
| className={showPickerEnforcedInput ? '' : 'date-time-picker__input-group'} | |||
| customInput={showPickerEnforcedInput && ( | |||
| customInput={showPickerEnforcedInput ? ( | |||
There was a problem hiding this comment.
addresses this
| @@ -130,18 +129,18 @@ | |||
| "babel-plugin-transform-react-remove-prop-types": "^0.4.24", | |||
| "babel-preset-react": "^6.24.1", | |||
| "bootstrap": "5.1.3", | |||
| "chromatic": "^6.24.1", | |||
| "chromatic": "^11.18.1", | |||
| "classnames": "^2.5.1", | |||
| "css-loader": "^6.11.0", | |||
| "eslint": "^8.57.1", | |||
There was a problem hiding this comment.
wish I could get eslint 9 in here. Seems like @brianCollinsUI you have experience with this upgrade? 👀 https://github.com/user-interviews/rails-server/pull/27389
There was a problem hiding this comment.
Yeah happy to help out here- is there an issue to track or can I make one? 👍
There was a problem hiding this comment.
Thanks Brian. Can probably drop an issue here: https://linear.app/user-interviews/project/ui-design-system-updates-4cb25d4fd32e/issues
There was a problem hiding this comment.
np- will try to get something up shortly- https://linear.app/user-interviews/issue/ENG-301/upgrade-eslint-to-9
| "istanbul-lib-instrument": "^6.0.0", | ||
| "jackspeak": "2.1.1", | ||
| "micromatch": "^4.0.8", | ||
| "normalize-package-data": "^3.0.0", | ||
| "path-to-regexp@npm:^1.7.0": "^1.9.0", | ||
| "semver": "^7.5.3" |
There was a problem hiding this comment.
are these 3 still stuck? think these were ones I recently fixed (micromatch and semver at least)
There was a problem hiding this comment.
I can double check, but I tried removing these and ran yarn why for them and saw some packages resolved to versions lower than what's set as the resolution
There was a problem hiding this comment.
I assume if these resolutions come from dependabot security updates, we could remove them all and see if any pop back up again? Not sure if that's the right approach tho?
There was a problem hiding this comment.
no if they are resolving to lower then we still need these for sure
There was a problem hiding this comment.
the older versions don't get patched for the fixes
| @@ -19,19 +19,18 @@ | |||
| "@tiptap/pm": "^2.7.4", | |||
| "@tiptap/react": "^2.7.4", | |||
| "@tiptap/suggestion": "^2.7.4", | |||
| "date-fns": "^3.6.0", | |||
| "date-fns": "^4.1.0", | |||
There was a problem hiding this comment.
I think we'll have to update rails server to match these when we release the new DS
yarn upgrade interactiveand upgraded packages to latestcss-loaderandeslintare the only remaining packages that need to be upgraded but weren't straightforwardLayoutcomponent sub directory since we never used it and removedreact-router-domas a dependency