Fix Dependabot #124 cross-spawn; Upgrade tiptap, css-loader@7
#1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also upgrades a host of Babel packages to the latest patch
jeffbax
changed the title
cross-spawn, upgrade CSS-Loader@7cross-spawn, upgrade css-loader@7
jeffbax
commented
Dec 4, 2024
| @@ -3,7 +3,7 @@ import PropTypes from 'prop-types'; | |||
|
|
|||
| import classNames from 'classnames'; | |||
|
|
|||
| import styles from './CheckboxButton.module.scss'; | |||
| import * as styles from './CheckboxButton.module.scss'; | |||
There was a problem hiding this comment.
these were the breaking changes for css-loader https://github.com/webpack-contrib/css-loader/releases/tag/v7.0.0
| "@tiptap/pm": "^2.7.4", | ||
| "@tiptap/react": "^2.7.4", | ||
| "@tiptap/suggestion": "^2.7.4", | ||
| "@tiptap/core": "^2.10.3", |
There was a problem hiding this comment.
Basically I clicked through each component in the app and confirmed they were loading with no iframe bundle errors, ran lint
jeffbax
commented
Dec 4, 2024
jeffbax
changed the title
cross-spawn, upgrade css-loader@7cross-spawn, upgrade tiptap, css-loader@7
jeffbax
changed the title
cross-spawn, upgrade tiptap, css-loader@7cross-spawn; Upgrade tiptap, css-loader@7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started fixing https://github.com/user-interviews/ui-design-system/security/dependabot/124
But kept pushing the rest of our dependencies and got everything to work except I didn't try the latest eslint given it is usually a huge pain in the butt.
Major upgrade of
cssloader@ 7.xUpgrades minor/patch:
Tested each component renders in Storybook:
