-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dataview search e2e Tests #1468
base: development
Are you sure you want to change the base?
Conversation
e2e-testing/cypress.env.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you undo the changes in the Cypress env
apps/web-mzima-client/src/env.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you not make any changes to the env file that is outside the e2e-testing folder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reverted the changes
apps/web-mzima-client/src/app/shared/components/search-form/search-form.component.html
Outdated
Show resolved
Hide resolved
@@ -18,7 +18,8 @@ const DataViewLocators = { | |||
publishPostBtn: '[data-qa="btn-publish-post"]', | |||
|
|||
postDetails: '[data-qa="post-details"]', | |||
|
|||
searchInput: '[data-qa="search-form__search-posts"]', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you refer to the previous comment about the [data-qa] attribute
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
615d3a0
to
bd33e69
Compare
bd33e69
to
ba03d4f
Compare
search_and_verify_results_with_special_characters(keyword) { | ||
const specialCharacterRegex = /^[!@#$%^&*()_+\-=\[\]{};':"\\|,.<>\/?`~]+$/; | ||
if (!specialCharacterRegex.test(keyword)) { | ||
throw new Error('Provided keyword does not contain only special characters'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this message consistent with what is returned in the mzima application
The tests seem to be failing for the last changes pushed. |
@@ -25,6 +25,32 @@ class DataViewFunctions { | |||
.children(DataViewLocators.postItem) | |||
.contains('Automated Title Response'); | |||
} | |||
search_and_verify_results(keyword) { | |||
this.click_data_view_btn(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before searching for the keyword, could you add a post with the keyword so that the post exists that you are searching for.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you mean to create a new post in the test block? because there are posts with the election keyword before now...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An update has been made for this, kindly review @shakirandagire
Wrote e2e automation tests to handle;