-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SMS channel support via Infobip and HttpSMS addons #4637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved Config files to the Laravel config directory - Added Infobip DataSource supporting SMS channel - Added HttpSMS DataSource supporting SMS channel - Small changes to AfricasTalking and Mteja addons - Adjusted V3 ConfigRepository to use the new config files
webong
force-pushed
the
feature/sms-channel-support
branch
from
October 30, 2023 04:40
d69160b
to
0630771
Compare
@Mh-Asmi help review this PR |
This works on feature USH-684, USH-686 |
Mh-Asmi
approved these changes
Oct 31, 2023
tuxpiper
pushed a commit
that referenced
this pull request
Nov 3, 2023
* wip: Add SMS channel support via Infobip and HttpSMS addons - Moved Config files to the Laravel config directory - Added Infobip DataSource supporting SMS channel - Added HttpSMS DataSource supporting SMS channel - Small changes to AfricasTalking and Mteja addons - Adjusted V3 ConfigRepository to use the new config files * chore: laravel package discovery for platform addons * feat: support incoming sms channel for httpsms and infobip providers * fix: phpcs lint issue * chore: fix fetching enabled sources on the data source manager * test: fix Receive message test * chore: update features config file * chore: update integration test
tuxpiper
pushed a commit
that referenced
this pull request
Nov 20, 2023
* wip: Add SMS channel support via Infobip and HttpSMS addons - Moved Config files to the Laravel config directory - Added Infobip DataSource supporting SMS channel - Added HttpSMS DataSource supporting SMS channel - Small changes to AfricasTalking and Mteja addons - Adjusted V3 ConfigRepository to use the new config files * chore: laravel package discovery for platform addons * feat: support incoming sms channel for httpsms and infobip providers * fix: phpcs lint issue * chore: fix fetching enabled sources on the data source manager * test: fix Receive message test * chore: update features config file * chore: update integration test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes the following changes:
Feature Requests:
USH-684, USH-686
Ping @ushahidi/platform