Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SMS channel support via Infobip and HttpSMS addons #4637

Merged
merged 11 commits into from
Nov 1, 2023

Conversation

webong
Copy link
Contributor

@webong webong commented Sep 5, 2023

This pull request makes the following changes:

  • Moved Config files to the Laravel config directory
  • Added Infobip DataSource supporting SMS channel
  • Added HttpSMS DataSource supporting SMS channel
  • Small changes to AfricasTalking and Mteja addons
  • Adjusted V3 ConfigRepository to use the new config files

Feature Requests:
USH-684, USH-686

Ping @ushahidi/platform

@webong webong force-pushed the feature/sms-channel-support branch from d69160b to 0630771 Compare October 30, 2023 04:40
@webong webong requested a review from Mh-Asmi October 30, 2023 05:21
@webong
Copy link
Contributor Author

webong commented Oct 30, 2023

@Mh-Asmi help review this PR

@webong
Copy link
Contributor Author

webong commented Oct 30, 2023

This works on feature USH-684, USH-686

@webong webong merged commit 5c21626 into develop Nov 1, 2023
4 checks passed
tuxpiper pushed a commit that referenced this pull request Nov 3, 2023
* wip: Add SMS channel support via Infobip and HttpSMS addons

- Moved Config files to the Laravel config directory
- Added Infobip DataSource supporting SMS channel
- Added HttpSMS DataSource supporting SMS channel
- Small changes to AfricasTalking and Mteja addons
- Adjusted V3 ConfigRepository to use the new config files

* chore: laravel package discovery for platform addons

* feat: support incoming sms channel  for httpsms and infobip  providers

* fix: phpcs lint issue

* chore: fix fetching enabled sources on the data source manager

* test: fix Receive message test

* chore: update features config file

* chore: update integration test
tuxpiper pushed a commit that referenced this pull request Nov 20, 2023
* wip: Add SMS channel support via Infobip and HttpSMS addons

- Moved Config files to the Laravel config directory
- Added Infobip DataSource supporting SMS channel
- Added HttpSMS DataSource supporting SMS channel
- Small changes to AfricasTalking and Mteja addons
- Adjusted V3 ConfigRepository to use the new config files

* chore: laravel package discovery for platform addons

* feat: support incoming sms channel  for httpsms and infobip  providers

* fix: phpcs lint issue

* chore: fix fetching enabled sources on the data source manager

* test: fix Receive message test

* chore: update features config file

* chore: update integration test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants