Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add only parameter for collection and save search #5009

Merged
merged 2 commits into from
Nov 6, 2024
Merged

add only parameter for collection and save search #5009

merged 2 commits into from
Nov 6, 2024

Conversation

Mh-Asmi
Copy link
Contributor

@Mh-Asmi Mh-Asmi commented Nov 1, 2024

This pull request makes the following changes:

  • add only parameter to collection
  • add pagination and search fields to collection
  • add only parameter to saved search
  • add pagination and search fields to saved search

Test checklist:

  • [ ]

  • I certify that I ran my checklist

Fixes ushahidi/platform# .

Ping @ushahidi/platform

@linear Linear
Copy link

linear bot commented Nov 1, 2024

USH-867 Apply only parameter on collection list API

@Mh-Asmi Mh-Asmi requested a review from ushahidlee November 1, 2024 19:44
ushahidlee
ushahidlee reviewed Nov 5, 2024
View reviewed changes
src/Ushahidi/Modules/V5/Http/Controllers/SavedSearchController.php
} //end index()


private function getSavedSearch(int $id, ?array $fields = null, ?array $haydrates = null)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haydrates?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha , I will fix it

ushahidlee
ushahidlee approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@ushahidlee ushahidlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Mh-Asmi Mh-Asmi merged commit 1fb3d92 into develop Nov 6, 2024
4 checks passed
@sentry-io Sentry.io
Copy link

sentry-io bot commented Nov 7, 2024 •
edited
Loading

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: Argument 2 passed to Ushahidi\Modules\V5\Http\Controllers\CollectionController::show() must be of... Ushahidi\Modules\V5\Http\Controllers\Collection... View Issue
  • ‼️ TypeError: Return value of Ushahidi\Modules\V5\Actions\Collection\Queries\FetchCollectionByIdQuery::getField... Ushahidi\Modules\V5\Http\Controllers\Collection... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ushahidlee ushahidlee ushahidlee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mh-Asmi @ushahidlee