-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: import resources from git repo or archive file #628
base: dev
Are you sure you want to change the base?
Conversation
b933b2d
to
e39cb71
Compare
Basic import functionality is now working. To test it with the included hello world plugin, go to the for git, set for file upload, first create an archive containing the necessary files (from the root dioptra dir in this branch) tar -czf plugins.tar.gz -C . plugins examples/hello-world.yaml dioptra.toml then set |
f27ae03
to
b4372ce
Compare
The following example illustrates how to configure a collection of resources | ||
including a Plugin, PluginParameterType, and Entrypoint. | ||
|
||
.. code:: TOML |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: update commented example in docs to match the example.
|
||
groupId = fields.Integer( | ||
attribute="group_id", | ||
# data_key="group", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a bug in marshmallow swagger docs. When the schema is used as form data, it ignores data_key
in the swagger UI.
f.seek(0) | ||
|
||
return f | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be:
yield f
f.close()
b4372ce
to
634c16e
Compare
b1fcb42
to
5099e70
Compare
3a116ca
to
8447f70
Compare
8447f70
to
695ff9b
Compare
converting back to Draft. Needs to update the client to support the new workflow. Tests should be updated to use client. Blocked by #694 |
resolves: