Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clean up issue tempalates #1331

Merged
merged 6 commits into from
Jun 10, 2022
Merged

Conversation

wd15
Copy link
Collaborator

@wd15 wd15 commented May 6, 2022

Clean up issue templates other than upload.yml, which will be dealt
with later. Includes a bug, feature and blank template.

Address #1299

Remember to tear down the live site when merging or closing this
pull request.

wd15 added 6 commits May 5, 2022 13:45
@pfhub
Copy link

pfhub commented May 6, 2022

The new PFHub live website is ready for review.

@wd15 wd15 requested a review from tkphd May 6, 2022 18:47
Copy link
Collaborator

@tkphd tkphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor docstring fix; LGTM

"""Generate a yaml file for test purposes

Args:
dir_: the result directory to write to
name: name of the result
id_: the benchmark id_ (e.g. "8a")
version: the version (e.g. "1")
name: the name of the simulation (e.g. "fipy1a")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"name" is defined twice. "add_name" is a bool.

@wd15 wd15 merged commit 9c3a8ec into usnistgov:master Jun 10, 2022
@wd15 wd15 deleted the bug-report-template branch June 10, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants