Papermill implementation for BM4 and BM8 #1497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark result notebooks now loop over a list of line plots.
Benchmark result notebooks now loop over a list of line plots.
Ensure broken CSV files or broken meta.yaml do not derail the upload build. - Allow broken CSV files not to fail (writes to log instead) - Allow the plot specs in YAML to specify the CSV columns to use
Tidy up uploads for BM4 that have broken links and broken meta.yaml specs.
Adding notebooks for BM4. The template changed for this purpose and, thus, all notebooks required updating.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
@wd15, the new version of the PFHub website is available at https://random-cat-1497.surge.sh |
|
@wd15, the new version of the PFHub website is available at https://random-cat-1497.surge.sh |
|
@wd15, the new version of the PFHub website is available at https://random-cat-1497.surge.sh |
|
@tkphd, ready for review. |
tkphd
approved these changes
Mar 16, 2023
results/benchmark8a.1.yaml
Outdated
| - name: 'solid_fraction_1' | ||
| layout: | ||
| x_label: 'Time [a.u.]' | ||
| y_label: 'Solid Fration, [a.u.]' |
There was a problem hiding this comment.
Suggested change
| y_label: 'Solid Fration, [a.u.]' | |
| y_label: 'Solid Fraction, [a.u.]' |
results/benchmark8a.1.yaml
Outdated
| - name: 'solid_fraction_2' | ||
| layout: | ||
| x_label: 'Time [a.u.]' | ||
| y_label: 'Solid Fration, [a.u.]' |
There was a problem hiding this comment.
Suggested change
| y_label: 'Solid Fration, [a.u.]' | |
| y_label: 'Solid Fraction, [a.u.]' |
results/benchmark8a.1.yaml
Outdated
| - name: 'solid_fraction_3' | ||
| layout: | ||
| x_label: 'Time [a.u.]' | ||
| y_label: 'Solid Fration, [a.u.]' |
There was a problem hiding this comment.
Suggested change
| y_label: 'Solid Fration, [a.u.]' | |
| y_label: 'Solid Fraction, [a.u.]' |
|
@wd15, the new version of the PFHub website is available at https://random-cat-1497.surge.sh |
|
Successful teardown of random-cat-1497.surge.sh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: