Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USWDS-Compile - POAM: July '24 #109

Merged
merged 2 commits into from
Jul 15, 2024
Merged

USWDS-Compile - POAM: July '24 #109

merged 2 commits into from
Jul 15, 2024

Conversation

mahoneycm
Copy link
Contributor

@mahoneycm mahoneycm commented Jul 8, 2024 •
edited
Loading

Summary

POAM for July 2024.

Vulnerabilities

No changes in vulnerabilities

3 moderate severity vulnerabilities

Testing instructions

  1. Install this branch on site
    • On Site's main branch, run:
npm install "https://github.com/uswds/uswds-compile/tree/cm-POAM-july-2024" --save
  1. Run gulp sass scripts and ensure compile runs as expected without error.
  2. Ensure no regressions when package is used to compile site

Dependency updates

Dependency name Previous version Updated version
postcss ^8.4.38 ^8.4.39

@mahoneycm mahoneycm changed the title Update non vulnverable packages USWDS-Compile - POAM: July '24 Jul 8, 2024
@mahoneycm mahoneycm mentioned this pull request Jul 8, 2024
Closed
10 tasks
@amyleadem amyleadem added this to the compile 1.2.0 milestone Jul 15, 2024
mejiaj
mejiaj reviewed Jul 15, 2024
View reviewed changes
Copy link
Contributor

@mejiaj mejiaj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mahoneycm I've updated with latest from develop. Can you test again and update the PR description? Otherwise LGTM.

I see the following on npm audit:

3 moderate severity vulnerabilities

amyleadem
amyleadem approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@amyleadem amyleadem left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Confirmed that after pulling in develop, the vulnerabilities shrink to 3 moderate vulnerabilities. If we also include the update to remove gulp-sourcemaps in PR #103, we get down to 0 vulnerabilities 🎉

Approving with the assumption that the PR description will be updated according to this comment.

mejiaj
mejiaj approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@mejiaj mejiaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating, LGTM.

@mejiaj mejiaj merged commit 5216241 into develop Jul 15, 2024
1 check passed
@mejiaj mejiaj deleted the cm-POAM-july-2024 branch July 15, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyleadem amyleadem amyleadem approved these changes

@mejiaj mejiaj mejiaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
USWDS Core Project Data
Status: Done
Milestone
compile 1.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mahoneycm @mejiaj @amyleadem