Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

question about symforce #72

Open
empty-spacebar opened this issue Jun 27, 2024 · 2 comments
Open

question about symforce #72

empty-spacebar opened this issue Jun 27, 2024 · 2 comments

Comments

@empty-spacebar
Copy link

Hi,

i noticed that ObVi-SLAM generates a c++ function named ReprojectionresidualWithJacobians012() using symforce but doesn't use it, i wonder why because recently i was accessing if symforce a suitable way for accelerating my code.
Doesn't it run faster?

Thanks.

@mandi1267
Copy link
Collaborator

Hi, thanks for checking out my work! Using the symforce Jacobian caused problems with long-term map extraction and Jacobian matrix rank deficiencies (which relies on the symforce generated Jacobian function). At the time of development, I decided that the observed speed-up did not justify additional time spent debugging these problems, so I switched back to autodifferentiatpion for Jacobian computation. I don't specifically recall problems with the online execution (though that was less my focus given the other problems observed), so the issues I found may not be problems for you. If I return to this investigation, I'll provide additional details / updates here.

@empty-spacebar
Copy link
Author

Can you explain more about long-term map extraction and Jacobian matrix rank deficiencies? I haven't found the problems you encountered.

Recently I was debuging with Aaron the mantainer of symforce, maybe I could talk with him about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants