Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update chiprtr so throughput scales correctly #136

Closed
wants to merge 1 commit into from
Closed

Update chiprtr so throughput scales correctly #136

wants to merge 1 commit into from

Conversation

AdityaAtulTewari
Copy link
Contributor

No description provided.

@AdityaAtulTewari AdityaAtulTewari requested a review from ywwu928 July 29, 2024 18:19
@AdityaAtulTewari AdityaAtulTewari marked this pull request as ready for review July 29, 2024 18:19
ywwu928
ywwu928 reviewed Jul 30, 2024
View reviewed changes
Copy link
Contributor

@ywwu928 ywwu928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's better to set an argument for an default bandwidth value and use that value to multiply the multiplier?

@AdityaAtulTewari
Copy link
Contributor Author

make sense, let me try to do that.

@AdityaAtulTewari
Copy link
Contributor Author

Super-seded.

@AdityaAtulTewari AdityaAtulTewari deleted the AdityaAtulTewari/update-chiprtr-config branch September 5, 2024 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywwu928 ywwu928 ywwu928 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdityaAtulTewari @ywwu928