Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update Grafana dashboard to reflect throttle metrics rename #147

Merged
merged 3 commits into from
Sep 29, 2024

Conversation

squat
Copy link
Contributor

@squat squat commented Mar 20, 2024

The metrics for throttling reasons have been renamed from nvidia_smi_clocks_throttle_reasons_* to nvidia_smi_clocks_event_reasons_*. This change has broken the Grafana dashboard.

xref: #123

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@utkuozdemir
Copy link
Owner

Thank you for the contribution. One thing though - I think it makes more sense to evolve the Grafana dashboard in a way that it would work both with old and new naming, so we keep it backward-compatible. Can you make it fallback to the old metric if the new metric is not there (I think there was a way to do that, but don't remember how).

squat and others added 3 commits September 29, 2024 17:44
The metrics for throttling reasons have been renamed from `nvidia_smi_clocks_throttle_reasons_*` to `nvidia_smi_clocks_event_reasons_*`. This change has broken the Grafana dashboard.

xref: utkuozdemir#123
The metrics exposed by the exporter no longer show `nvidia_smi_clocks_throttle_reasons_*` but rather `nvidia_smi_clocks_event_reasons_*`.
Keep it backwards-compatible.

Signed-off-by: Utku Ozdemir <[email protected]>
@utkuozdemir utkuozdemir merged commit f3a5a48 into utkuozdemir:master Sep 29, 2024
@squat squat deleted the patch-1 branch September 29, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants