-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial library iteration #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the comments
Co-authored-by: Christy Jacob <[email protected]>
@Meldiron I had an idea. Could be nice to open multiple issues for the community for adding new adapters for other logging platforms. We should probably also have a simple contribution guide. |
@christyjacob4 Let's rename repository to |
Prepared GH issue for a provider. Please review it before I create an issue for each provider. #4 |
Does this library need to support PHP7.4? Can we run with PHP8 or 8.1? |
@eldadfux Your decision probably. I would guess code can work without problem on both. With v8, there might be features to make code cleaner. |
@Meldiron We can stick to 8.0 and 8.1. |
@kodumbeats @eldadfux Upgraded requirements to PHP 8.0 in commit db66b8c. Please let me know if that is all or I missed something. |
Does that even exist?? 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor style comment.
Please make sure all the opening braces in all the functions start in new lines. Rest looks great! Amazing job 🥳
You should be good 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is beautiful work. The codebase looks much cleaner with the new changes, and implementation of a new adapter looks much easier. I added a few comments, most of them regarding naming changes.
Co-authored-by: Eldad A. Fux <[email protected]>
No description provided.