Added Pushy Messaging Adapter #41
Conversation
|
Hey, Due to time constraints, I'm going to mark this PR When it is merged, we'll contact you for Appwrite-specific Hacktoberfest swag. Thanks for helping us improve Appwrite! |
| */ | ||
| public function getMaxMessagesPerRequest(): int | ||
| { | ||
| return 1000; |
There was a problem hiding this comment.
Did you confirm from the documentation that this limit is 1000 for Pushy?
There was a problem hiding this comment.
@Diveshmahajan4 The limit here should be 100000
|
Hey @Diveshmahajan4! 👋🏼 Thank you for your contribution. The PR looks good overall. Please run |
|
Hello @Diveshmahajan4 Thank you for your contribution to Hacktoberfest 2023! We've noticed that your PR is still pending and requires some updates based on our engineering team's feedback. We would love to see your PR successfully merged and send you the Appwrite swag as a token of appreciation. To remain eligible for the swag, please address the pending suggestions and/or ensure the tests pass by Friday, November 17th. If the PR isn't updated by then, we will unfortunately have to close it due to the end of the Hacktoberfest event. Looking forward to your updates and thank you! |
|
Hey there! There were a lot of big PRs during this Hacktoberfest, and we wanted to give everyone ample time to collaborate with our engineering team. If you were able to merge your PRs during October, amazing. If it’s still not merged, don’t worry about it either. Either way, we’ve got your Hacktoberfest swag minted and ready to ship. Please comment with your Discord username here so we can contact you about your shipping information to deliver your Hacktoberfest swag. |
|
Thanks a lot for providing me the opportunity to contribute!
Discord Username: diveshm
…On Tue, Apr 9, 2024 at 1:40 AM Vincent (Wen Yu) Ge ***@***.***> wrote:
Hey there! There were a lot of big PRs during this Hacktoberfest, and we
wanted to give everyone ample time to collaborate with our engineering
team. If you were able to merge your PRs during October, amazing. If it’s
still not merged, don’t worry about it either. Either way, we’ve got your
Hacktoberfest swag minted and ready to ship.
Please comment with your Discord username here so we can contact you about
your shipping information to deliver your Hacktoberfest swag.
—
Reply to this email directly, view it on GitHub
<#41 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWWE5IL4CJL4OBA5BFC7L63Y4L2TZAVCNFSM6AAAAAA5TUNFCGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBTGU2TOMZVHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Will reach out soon. Appreciate patience. Adding you to a giant list of people to reach out to! |
| */ | ||
| public function process(Push $message): string | ||
| { | ||
|
|
| body: \json_encode([ | ||
| 'to' => $message->getTo(), | ||
| 'data' => $message->getData(), | ||
| 'notifications' => [ |
There was a problem hiding this comment.
I think this should be notification instead of notifications
| */ | ||
| public function getMaxMessagesPerRequest(): int | ||
| { | ||
| return 1000; |
There was a problem hiding this comment.
@Diveshmahajan4 The limit here should be 100000
| public function process(Push $message): string | ||
| { | ||
|
|
||
| return $this->request( |
There was a problem hiding this comment.
This should build a structured response consistent with other adapters, please check APNS/FCM for an idea on how to do so
What does this PR do?
Adds a new Push Adapter for sending push notification via Pushy.
Test Plan
Related PRs and Issues
Closes appwrite/appwrite#6400
Have you read the Contributing Guidelines on issues?
Yes