Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update dart commads #5

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: update dart commads #5

wants to merge 1 commit into from

Conversation

christyjacob4
Copy link
Contributor

The dart install and build commands were using the flutter command which is a client side command unavailable in dart server side environments

@@ -37,12 +37,12 @@ public function getFiles(): array

public function getInstallCommand(): string
{
return 'flutter pub get';
return 'dart pub get';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm able to verify dart pub get but not dart build. I found dart run and webdev build --output web:build instead in the docs. @Meldiron @stnguyen90 any idea?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually dont use these methods for install and build commands I think. Right?

Copy link
Contributor

@Meldiron Meldiron Sep 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

}

public function getBuildCommand(): string
{
return 'flutter build';
return 'dart build';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants