Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Now in the branding option if we hit the wrong URL, branding page shows the HTTP 400 NOT FOUND #242

Open
wants to merge 2 commits into
base: 1.1
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Resources/config/routes/private-agents.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ helpdesk_member_knowledgebase_related_article_xhr:

# Members knowledgebase setting routing resources
helpdesk_member_knowledgebase_theme:
path: /branding/theme/{type}
path: /branding/theme/
controller: Webkul\UVDesk\SupportCenterBundle\Controller\Branding::theme
defaults: { type: '' }

Expand Down
2 changes: 1 addition & 1 deletion Resources/views/Templates/sidepanel.html.twig
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
<h3>{{'Tags'|trans}}</h3>
<div class="uv-tags">
{% for tag in articleTags %}
<span><a href="{{path('helpdesk_knowledgebase_tag', {'tag': tag.id, 'name': tag.name})}}">{{tag.name}}</a></span>
<span><a href="{{path('helpdesk_knowledgebase_tag', {'tag': tag.id, 'tag': tag.id})}}">{{tag.name}}</a></span>
{% endfor %}
</div>
</aside>
Expand Down