Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Altimeter Point Plotting Function #21

Closed
Jack-Hayes opened this issue Nov 20, 2024 · 3 comments · Fixed by #31
Closed

Create Altimeter Point Plotting Function #21

Jack-Hayes opened this issue Nov 20, 2024 · 3 comments · Fixed by #31
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@Jack-Hayes
Copy link
Member

Hey @scottyhq ! Just wanted to get your thoughts on the below idea after I spent a lot of time messily plotting PCD candidate sites:
Idea to create a quick plotting function for LiDAR extent, stereo extent, and GEDI and ICESat-2 point overlaps. Probably need a separate package 'plot' (ie. coincident.plot.plot_altimeter_points() ?)

Take the results of cascading_search() (and the input GeoDataframe/GeoSeries into cascading_search()) and plot all overlaps onto a small figure with a quick method call.

ie. If you know a 3dep site (variable name gf_wesm) has overlaps, plug it into this function:

  • Call the cascading_search() function inside this larger plotting function
  • Plot the gf_wesm and gf_stereo extents
  • Use the granule names for GEDI and ICESat-2 from cascading_search() to pass into a SlideRule call (to get filtered/quality-flagged ICESat-2 and GEDI points)
    • Not sure if building all SlideRule dependencies into this library is desirable
  • Plot the GEDI and ICESat-2 points (ensure same color ramp scale)

This way you can do a quick check if your overlap area contains a satisfactory amount of filtered/quality-flagged ICESat-2 and GEDI points unaffected by clouds and such.

@Jack-Hayes Jack-Hayes self-assigned this Nov 20, 2024
@Jack-Hayes Jack-Hayes added enhancement New feature or request question Further information is requested labels Nov 20, 2024
@scottyhq
Copy link
Member

Probably need a separate package 'plot' (ie. coincident.plot.plot_altimeter_points()

I've gone back and forth on including built-in plots beyond basic geopandas.plot/explore and xarray.plot versus just focusing on search and I/O and leaving all visualizations up to users. On one hand, everyone has different aesthetic preferences and it tends to require many dependencies, on the other, as you mention it's ultimately nice to have a quick visual check of results! Your plan sounds good if you want to open a draft PR!

Not sure if building all SlideRule dependencies into this library is desirable

Yes, I think we should add it #6, I'll wrap that up tomorrow!

@Jack-Hayes
Copy link
Member Author

Jack-Hayes commented Jan 3, 2025

Hi @scottyhq ! I'm thinking we can close this issue and focus on flushing out #33 for plotting efforts?

@scottyhq
Copy link
Member

scottyhq commented Jan 3, 2025

yep, sounds good to me!

@scottyhq scottyhq closed this as completed Jan 3, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in Coincident v1.0 Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants