Refactor plotting functions into submodule #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
scottyhq
commented
Dec 16, 2024
|
|
||
|
|
||
| @network | ||
| @pytest.mark.skip(reason="https://github.com/uw-cryo/coincident/issues/35") |
There was a problem hiding this comment.
disabling slideruleIO tests for now, as I can't get these tests to run consistently locally or in CI... #35
scottyhq
commented
Dec 16, 2024
| @network | ||
| @maxar_authenticated | ||
| @pytest.mark.filterwarnings("ignore:the actual content type does not match") | ||
| @pytest.mark.skip(reason="temporarily skip to see if CI failing due to async code") |
There was a problem hiding this comment.
On a hunch, I disabled this b/c other tests started failing with obscure errors on CI. Running locally I do not see these types of errors, will have to dig into it later, maybe look at how stac-asset does testing (https://github.com/stac-utils/stac-asset/tree/main/tests)
> warnings.warn(pytest.PytestUnraisableExceptionWarning(msg))
E pytest.PytestUnraisableExceptionWarning: Exception ignored in: <function _SelectorTransport.__del__ at 0x10251a200>
E
E Traceback (most recent call last):
E File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/asyncio/selector_events.py", line 710, in __del__
E _warn(f"unclosed transport {self!r}", ResourceWarning, source=self)
E ResourceWarning: unclosed transport <_SelectorSocketTransport fd=28>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
api.rstAlso adds more tests for sliderule IO. cc @Jack-Hayes