Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove tags from frontend services #167

Open
wants to merge 3 commits into
base: release-v2
Choose a base branch
from
Open

Conversation

gregmaxin
Copy link
Member

@gregmaxin gregmaxin commented Mar 20, 2022

Notion ticket link

Implementation description

Instructions to remove auth and file-storage
Remove Auth

  • Change "apolloClient" to not use AuthLink in "frontend\src\index.tsx"
  • Remove Authorization headers from all requests (x6) in "frontend\src\APIClients\EntityAPIClient.ts
  • Delete BearerToken definitions from all functions (x6) in "frontend\src\APIClients\EntityAPIClient.ts"
  • Remove the "authHeadersParts" and the following if statement if not using Auth in "frontend\src\APIClients\BaseAPIClient.ts
  • Replace all "PrivateRoute" with "Route" in "frontend\src\App.tsx"

Remove File Storage

  • Change "Form Data" to "EntityRequest" (x2) in "frontend\src\APIClients\EntityAPIClient.ts"
  • Remove "File" from graphGLResult variables in "frontend\src\components\crud\CreateForm.tsx"
  • Remove all multipart code and replace the results line with "result = await EntityAPIClient.create({ formData });" in "frontend\src\components\crud\CreateForm.tsx"
  • Remove the line "" from the return in "frontend\src\components\crud\CreateForm.tsx"
  • Remove the fileName column from "create Column" in "frontend\src\components\crud\DisplayTableContainer.tsx"
  • Remove "downloadEntityFile={downloadEntityFile}" from return inside frontend\src\components\crud\DisplayTableContainer.tsx
  • Remove all multipart code and replace the results line with "result = await EntityAPIClient.create({ formData });" in "frontend\src\components\crud\UpdateForm.tsx"
  • Remove the line "" from the return in "frontend\src\components\crud\UpdateForm.tsx"

Steps to test

What should reviewers focus on?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@gregmaxin gregmaxin marked this pull request as draft March 20, 2022 07:41
@sherryhli sherryhli changed the base branch from main to release-v2 March 24, 2022 21:29
@gregmaxin gregmaxin marked this pull request as ready for review April 19, 2022 06:47
@gregmaxin gregmaxin requested a review from sherryhli April 22, 2022 03:48
@hanlinc27 hanlinc27 changed the title Remove tags from Frontend feat: remove tags from Frontend May 22, 2022
@hanlinc27 hanlinc27 changed the title feat: remove tags from Frontend feat: remove tags from frontend services May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant