Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge in current changes from branch 'windtunnel' #5

Merged
merged 13 commits into from
Nov 12, 2015
Merged

Conversation

bsmithyman
Copy link
Member

Several changes included here:

General

  • Solvers are smarter
  • Metaclass behaviour is much more robust
  • More class hierarchy allows for inheriting what we want
  • Sources are much improved

Sources

  • Source locations are now handled as vectors
  • This allows returning multiple RHS vectors
  • The solver has been modified to automatically handle these
  • Sources can now be sparse (up to the point of RHS evaluation; see source.py:SparseKaiserSource and solver.py)

MultiFreq / Parallel

  • DiscretizationWrappers allow for flexible handling of composite problems
  • Implemented MultiFreq and MiniZephyr25D using DiscretizationWrapper, and including parallel support

Test Coverage

… dimension (x, z; in principle y) on the second axis. This makes it possible to vectorize (i.e., to return right-hand-side vectors for all sources in one call).
…o implement proper SparseKaiserSource, and include a simple wrapper around it to return dense versions from KaiserSource.

NB: New solver architecture should handle sparse sources just fine.
…ary, because the sparse sources can be very easily multiplied by a diagonal to scale the terms.
… somehow it was discovered that the scaling was wrong in SimpleSource...
SCFilter takes a collection of AttributeMapper classes, and computes the combined requirements and optional arguments. Then, any systemConfig passed through it will be stripped of irrelevant entries, and an error will be raised if a required entry isn't provided. This is useful, for example, before Pickling and sending over a network.

BaseSCCache is a new base class that caches systemConfig, so that this functionality can be inherited without a DiscretizationWrapper.
@bsmithyman
Copy link
Member Author

Hey Shaun, thoughts on this? New source vector stuff is included, so it might break old code.

ShaunHadden added a commit that referenced this pull request Nov 12, 2015
Merge in current changes from branch 'windtunnel'
@ShaunHadden ShaunHadden merged commit be0ded2 into master Nov 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants