[http] Provide proxies for HTTP methods

This prevents these methods not working when destructured from the top-level of
a file.

packages/shelter/src/http.ts

@@ -1,19 +1,39 @@
 import { after, instead } from "spitroast";
-import { DiscordHTTP, HTTPRequest, HTTPResponse } from "./types";
+import { DiscordHTTP, HTTPApi, HTTPRequest, HTTPResponse } from "./types";
+
+const methods = ["get", "post", "put", "patch", "del"];
 
 let resolve: () => void;
 export let ready = new Promise<void>((res) => (resolve = res));
-
 export let discordHttp: DiscordHTTP;
+
+const api: HTTPApi = {
+  intercept,
+  ready,
+  get _raw() {
+    return discordHttp;
+  },
+};
+
+for (const fun of methods) {
+  api[fun] = (...args: any[]) => {
+    if (discordHttp === undefined) throw new Error("HTTP method used before API was ready");
+    return discordHttp[fun](...args);
+  };
+}
+
+export default api;
+
 const unpatch = after("bind", Function.prototype, function (args, res) {
   if (args.length !== 2 || args[0] !== null || args[1] !== "get") return;
   unpatch();
   return function (...args) {
     // I don't know why, but for the first call `this` is Window
     if (this !== window) {
+      this.get = res;
       discordHttp = this;
+      Object.assign(api, discordHttp);
       resolve();
-      this.get = res;
     }
     return res(...args);
   };
@@ -22,7 +42,7 @@ const unpatch = after("bind", Function.prototype, function (args, res) {
 export let unpatchHttpHandlers;
 function patchHttpHandlers() {
   if (unpatchHttpHandlers) return;
-  const patches = ["get", "post", "put", "patch", "del"].map((fun) =>
+  const patches = methods.map((fun) =>
     instead(fun, discordHttp, async (args, original) => {
       let req = args[0];
       if (typeof req === "string") {

packages/shelter/src/types.ts

@@ -155,9 +155,6 @@ export interface DiscordHTTP {
   put: HTTPFunction;
   patch: HTTPFunction;
   del: HTTPFunction;
-  getAPIBaseURL: string;
-  V6OrEarlierAPIError: Error;
-  V8APIError: Error;
 }
 
 export type HTTPApi = {

packages/shelter/src/windowApi.ts

@@ -11,7 +11,7 @@ import * as plugins from "./plugins";
 import { registerSection } from "./settings";
 import * as storage from "./storage";
 import { observe } from "./observer";
-import { discordHttp, intercept, ready } from "./http";
+import http from "./http";
 import { HTTPApi } from "./types";
 import { constants } from "./constants";
 
@@ -22,7 +22,6 @@ function without<T extends Record<string, any>, TK extends string>(object: T, ..
   return cloned as Omit<T, TK>;
 }
 
-let http;
 const windowApi = async (unloads) => {
   const dispatcher = await flux.getDispatcher();
 
@@ -38,18 +37,7 @@ const windowApi = async (unloads) => {
       "modifiedSym",
       "initDispatchLogger",
     ),
-    get http(): HTTPApi {
-      if (discordHttp === undefined) {
-        return { intercept, ready };
-      }
-
-      return (http ??= {
-        ...discordHttp,
-        _raw: discordHttp,
-        intercept,
-        ready,
-      });
-    },
+    http,
     constants,
     patcher: without(patcher, "unpatchAll"),
     solid,