[BLAS] Fix complex header inclusion and multi_ptr cast #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
multi_ptr cast Newest compiler nightly change include path for header, this change requires to update to properly check and include sycl complex headers. multi_ptr cast as it is caused ambigous call to static_cast, this patch work-around the issue overloading load function using raw_pointers. Signed-off-by: nscipione <[email protected]>
Signed-off-by: nscipione <[email protected]>
Rbiessy
reviewed
Jan 10, 2025
Signed-off-by: nscipione <[email protected]>
Rbiessy
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch update the include path and check for complex header, due to compiler changes of default include path.
After updating the header inclusion, an issue with
sycl::multi_ptrcast ofsycl::complextype arose.This patch work-around the issue by overloading the load/store function of the internal vector representation for complex type.
Attaching logs using oneMath test both using a recent nightly and latest icpx version (oneAPI 2025):