-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC|oneMKL]Enable programmatic versioning #561
Conversation
@uxlfoundation/oneapi-spec-maintainers: Please review this versioning proposal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not understand what is being proposed here.
Is the idea that each implementation of the spec gets to decide how to provide a version to the user (whether by a version string, a #define
, an int getSpecVersion()
function)? Then this change to the spec only specifies that the end of this string/macro/int has a certain representation?
Yes. The goal of this RFC is to ensure that every implementation of the spec provides a numerically comparable value for its compliance with the spec version, through the proposed macros. The implementation can additionally provide more ways to query that information, like APIs, but we do not mandate that in this proposal. |
source/elements/oneMKL/source/architecture/other_architecture.inc.rst
Outdated
Show resolved
Hide resolved
@akukanov @mkrainiuk @rscohn2 @spencerpatty if everything looks okay, then please provide your approval. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Acceptable from my perspective. Approved
@aelizaro @paveldyakov @lhuot @zettai-reido @sknepper can you please provide your reviews? Thank you! |
source/elements/oneMKL/source/architecture/other_architecture.inc.rst
Outdated
Show resolved
Hide resolved
For your information, below is what I propose for defining a spec version macro for oneDPL. Use as you like; in case of feedback please comment in the PR #591.
|
ca8205c
to
602c87d
Compare
Motivation
Inspiration
revision
number:MAJOR.MINOR
version, with ongoing progress marked asTechnical Report <number>
. The_OPENMP
macro provides a release date which maps onto a specification version, like this:Proposal
<MAJOR><MINOR><REVISION>
such that MINOR and REVISION have two digits.