applied Mike comments about foraech (#1758)

include/oneapi/dpl/internal/distributed_ranges_impl/sp/algorithms/for_each.hpp

@@ -21,7 +21,6 @@
 #include "../detail.hpp"
 #include "../init.hpp"
 #include "../util.hpp"
-#include "../views/zip.hpp"
 #include "execution_policy.hpp"
 
 namespace oneapi::dpl::experimental::dr::sp
@@ -35,6 +34,7 @@ for_each(ExecutionPolicy&& policy, R&& r, Fn fn)
         std::is_same_v<std::remove_cvref_t<ExecutionPolicy>, sycl_device_collection>);
 
     std::vector<sycl::event> events;
+    events.reserve(stdrng::size(ranges::segments(r)));
 
     for (auto&& segment : ranges::segments(r))
     {
@@ -47,7 +47,7 @@ for_each(ExecutionPolicy&& policy, R&& r, Fn fn)
         auto first = stdrng::begin(local_segment);
 
         auto event = dr::__detail::parallel_for(q, sycl::range<>(stdrng::distance(local_segment)),
-                                                [=](auto idx) { fn(*(first + idx)); });
+                                                [=](auto idx) { fn(first[idx]); });
         events.emplace_back(event);
     }
     __detail::wait(events);

include/oneapi/dpl/internal/distributed_ranges_impl/sp/algorithms/iota.hpp

@@ -20,6 +20,7 @@
 
 #include "../../detail/std_ranges_shim.hpp"
 #include "../../views/iota.hpp"
+#include "../views/zip.hpp"
 #include "for_each.hpp"
 
 namespace oneapi::dpl::experimental::dr::sp

include/oneapi/dpl/internal/distributed_ranges_impl/sp/distributed_vector.hpp

@@ -191,15 +191,15 @@ struct distributed_vector
     {
         size_type segment_id = pos / segment_size_;
         size_type local_id = pos % segment_size_;
-        return *(segments_[segment_id].begin() + local_id);
+        return segments_[segment_id][local_id];
     }
 
     const_reference
     operator[](size_type pos) const
     {
         size_type segment_id = pos / segment_size_;
         size_type local_id = pos % segment_size_;
-        return *(segments_[segment_id].begin() + local_id);
+        return segments_[segment_id][local_id];
     }
 
     size_type