Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[onedpl][ranges][productization] Range API productization, MVP plan, Part 1 #1457

Merged
merged 159 commits into from
Sep 3, 2024

Conversation

MikeDvorskiy
Copy link
Contributor

@MikeDvorskiy MikeDvorskiy commented Mar 20, 2024

[onedpl][ranges][productization] Range API productization, MVP plan

oneDPL Range API productization:

Support the minimal algorithm set, according to MVP plan. Part 1 (this patch): for_each, transform, find, find_if, find_if_not, any_of, all_of, none_of, adjacent_find, search, search_n.
A common test (functor, projection, vector, usm_vector, std::subrange, std::span, sycl::buffer)

(A reference to the previous PR to refresh the conversation if it needs: #1405)

A reference to the proposal for C++ parallel ranges algorithms, which this PR relies on: https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2024/p3179r1.html

@MikeDvorskiy MikeDvorskiy marked this pull request as draft March 20, 2024 14:07
@MikeDvorskiy MikeDvorskiy changed the title [onedpl][ranges][productization] Range API productization, MVP plan [onedpl][ranges][productization] Range API productization, MVP plan, Part 1 Mar 21, 2024
@MikeDvorskiy MikeDvorskiy force-pushed the dev/mdvorski/std_ranges_support_mvp branch 2 times, most recently from 389a1ae to f27166e Compare March 21, 2024 11:16
@MikeDvorskiy MikeDvorskiy marked this pull request as ready for review March 21, 2024 11:22
@MikeDvorskiy MikeDvorskiy force-pushed the dev/mdvorski/std_ranges_support_mvp branch 2 times, most recently from e43a2c8 to 145ac98 Compare March 25, 2024 17:58
include/oneapi/dpl/ranges Outdated Show resolved Hide resolved
test/parallel_api/ranges/std_ranges_test.h Outdated Show resolved Hide resolved
@MikeDvorskiy MikeDvorskiy force-pushed the dev/mdvorski/std_ranges_support_mvp branch from bf18094 to dac7c2a Compare March 27, 2024 17:47
@MikeDvorskiy MikeDvorskiy force-pushed the dev/mdvorski/std_ranges_support_mvp branch 2 times, most recently from 1ffbab0 to 87b43a3 Compare April 5, 2024 14:36
@MikeDvorskiy MikeDvorskiy added this to the 2022.6.0 milestone Apr 8, 2024
@MikeDvorskiy MikeDvorskiy force-pushed the dev/mdvorski/std_ranges_support_mvp branch 3 times, most recently from 72e28c8 to 850b408 Compare April 15, 2024 10:44
@ValentinaKats ValentinaKats modified the milestones: 2022.6.0, 2022.7.0 Apr 15, 2024
@MikeDvorskiy MikeDvorskiy force-pushed the dev/mdvorski/std_ranges_support_mvp branch from 850b408 to 212af8f Compare May 7, 2024 15:42
@MikeDvorskiy MikeDvorskiy force-pushed the dev/mdvorski/std_ranges_support_mvp branch 3 times, most recently from 05df261 to 3c2713b Compare May 22, 2024 09:56
@MikeDvorskiy MikeDvorskiy force-pushed the dev/mdvorski/std_ranges_support_mvp branch from ee9ec9e to be7a45f Compare August 30, 2024 21:02
Signed-off-by: Dmitriy Sobolev <[email protected]>
Signed-off-by: Dmitriy Sobolev <[email protected]>
Signed-off-by: Dmitriy Sobolev <[email protected]>
@dmitriy-sobolev dmitriy-sobolev force-pushed the dev/mdvorski/std_ranges_support_mvp branch from 655ad41 to cb43237 Compare September 1, 2024 11:38
@dmitriy-sobolev dmitriy-sobolev force-pushed the dev/mdvorski/std_ranges_support_mvp branch from cb43237 to f6aaaa4 Compare September 1, 2024 11:40
Copy link
Contributor

@rarutyun rarutyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR is ready. We will try to add insignificant fixes before code freeze (like removing <span> header) but other than that we don't have time to make it anyhow better

@dmitriy-sobolev dmitriy-sobolev merged commit 954ce1a into main Sep 3, 2024
21 of 22 checks passed
@dmitriy-sobolev dmitriy-sobolev deleted the dev/mdvorski/std_ranges_support_mvp branch September 3, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants