Fix __parallel_partial_sort call without wait/get
#1460
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeyKopienko
force-pushed
the
dev/skopienko/fix__parallel_partial_sort_call
branch
from
c1baf51 to
b9d1217
Compare
SergeyKopienko
changed the title
__parallel_partial_sort call without wait/get__parallel_partial_sort call without wait/get
SergeyKopienko
changed the title
__parallel_partial_sort call without wait/get__parallel_partial_sort call without wait/get
SergeyKopienko
commented
Mar 21, 2024
| _BackendTag{}, __par_backend_hetero::make_wrapped_policy<__partial_sort_2>(__exec), | ||
| __par_backend_hetero::make_iter_mode<__par_backend_hetero::access_mode::read_write>(__buf_first), | ||
| __par_backend_hetero::make_iter_mode<__par_backend_hetero::access_mode::read_write>(__buf_mid), | ||
| __par_backend_hetero::make_iter_mode<__par_backend_hetero::access_mode::read_write>(__buf_last), __comp); | ||
| if constexpr (!decltype(__buf).IsSync{}) |
There was a problem hiding this comment.
One more way is to add .wait() call here without any conditions and de-facto existing synchronizations inside __parallel_partial_sort (__parallel_partial_sort_impl) due sycl::accessor synchronizations.
SergeyKopienko
force-pushed
the
dev/skopienko/fix__parallel_partial_sort_call
branch
from
54dbbf3 to
542f802
Compare
added 6 commits
March 22, 2024 15:27
SergeyKopienko
force-pushed
the
dev/skopienko/fix__parallel_partial_sort_call
branch
from
542f802 to
1bbd90a
Compare
SergeyKopienko
deleted the
dev/skopienko/fix__parallel_partial_sort_call
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we add some comments why we shouldn't call .wat() for
__parallel_partial_sortresult in concrete case.Another variant (in the last commit) - to add
IsSynctype into__bufferimplementation based onsycl::bufferSee also #1261