Performance improvements: insert break into __early_exit_find_or
#1624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eak into __early_exit_find_or Signed-off-by: Sergey Kopienko <[email protected]>
SergeyKopienko
requested review from
julianmi,
MikeDvorskiy,
AidanBeltonS,
danhoeflinger,
adamfidel,
dmitriy-sobolev and
akukanov
and removed request for
AidanBeltonS
SergeyKopienko
changed the title
break into __early_exit_find_orbreak into __early_exit_find_or
danhoeflinger
approved these changes
Jun 17, 2024
There was a problem hiding this comment.
Very good improvement.
I didn't understand at first, but because we don't use SLM, and we limit the number of groups to the number of compute units, this allows __n_iter to grow with N, basically unbounded. This means that even though we likely need ALL work-items in a subgroup to see the early exit condition to get a benefit here (due to implementation as masked vector operations), we might have a very large __n_iter, and with data that has a reasonable chance to find the criteria throughout, this can still provide big savings.
SergeyKopienko
deleted the
dev/skopienko/insert_break_into_early_exit_find_or
branch
SergeyKopienko
added a commit
that referenced
this pull request
Jul 10, 2024
This reverts commit 224acf7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this error we fixing performance issue in the
__early_exit_find_or::operator():breakfor-loop after call__found_local.store(1);This performance issue has been found during preparation of the PR #1617