Support scratch space without result space #1773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianmi
requested review from
danhoeflinger,
SergeyKopienko,
mmichel11 and
adamfidel
include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl_utils.h
Outdated
Show resolved
Hide resolved
…ls.h Co-authored-by: Sergey Kopienko <[email protected]>
mmichel11
approved these changes
Aug 9, 2024
danhoeflinger
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch extends
__result_and_scratch_storageto support cases where no result space is required. This removes the overhead of allocating result storage even when it is unneeded such as in the dummy container introduced in #1770. The signature is kept intact to support the different scan kernels.There is also some code cleanup and the usage in reduce is aligned with the recently merged scan. The container is also passed by reference to the reduce kernels to prevent copies.