Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Update broken macro for comparison #1789

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

danhoeflinger
Copy link
Contributor

Version 2025.0.0 of icpx will still has the issue when combined with MSVC STD implementation comparing std::optional, std::pair etc.
Updating the version broken macro to reflect this.

@danhoeflinger danhoeflinger added this to the 2022.7.0 milestone Aug 21, 2024
@danhoeflinger danhoeflinger added the test Test only Change label Aug 21, 2024
Copy link
Contributor

@mmichel11 mmichel11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@SergeyKopienko SergeyKopienko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danhoeflinger danhoeflinger merged commit d612eb8 into main Aug 26, 2024
22 checks passed
@danhoeflinger danhoeflinger deleted the dev/dhoeflin/update_broken_macro branch August 26, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Test only Change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants