Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ENDL with TBB_ENDL to reduce the likehood of conflicts ... #1220

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

martin-marinov77
Copy link
Contributor

... with application source code.

Description

As per the title, ENDL is renamed to TBB_ENDL. ENDL is a very general macro name and conflicted in our source code with a symbol from another library.

Fixes # - issue number(s) if exists

  • - git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details)

Type of change

Choose one or multiple, leave empty if none of the other choices apply

Add a respective label(s) to PR if you have permissions

  • bug fix - change that fixes an issue
  • new feature - change that adds functionality
  • tests - change in tests
  • infrastructure - change in infrastructure and CI
  • documentation - documentation update

Tests

  • added - required for new features and some bug fixes
  • not needed

Documentation

  • updated in # - add PR number
  • needs to be updated
  • not needed

Breaks backward compatibility

  • Yes
  • No
  • Unknown

Notify the following users

List users with @ to send notifications

Other information

Copy link
Contributor

@isaevil isaevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just curious, what does "ENDL" expand into in your application code then?

@martin-marinov77
Copy link
Contributor Author

LGTM. Just curious, what does "ENDL" expand into in your application code then?

Thank you for the review.

We use have a library with a the following definition (inside a namespace):
const char ENDL = '\n';

The TBB ENDL marco definition is causing compilation errors when the TBB macro is expanded in place of ENDL.

@isaevil isaevil merged commit bec5d99 into uxlfoundation:master Oct 19, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants