Fix tests compilation on OpenBSD

[pavelkumbrasev]

Description

This test won't work on OpenBSD because it doesn't have RLIMIT_AS. So this patch disables this test.

#1015

• - git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details)

Type of change

Choose one or multiple, leave empty if none of the other choices apply

Add a respective label(s) to PR if you have permissions

• bug fix - change that fixes an issue
• new feature - change that adds functionality
• tests - change in tests
• infrastructure - change in infrastructure and CI
• documentation - documentation update

Tests

• added - required for new features and some bug fixes
• not needed

Documentation

• updated in # - add PR number
• needs to be updated
• not needed

Breaks backward compatibility

• Yes
• No
• Unknown

Notify the following users

List users with @ to send notifications

Other information

[sarathnandu]

Copyright check flagged otherwise LGTM!

[brad0]

It is test_malloc_compliance.cpp that has the issue with RLIMIT_AS.

This one seemed to be an issue with comparison of integers of different signs.

[1/155] /home/brad/tmp/ffmpeg-ports/ports/pobj/tbb-2021.10.0-rc1/bin/c++  -I/home/brad/tmp/ffmpeg-ports/ports/pobj/tbb-2021.10.0-rc1/oneTBB-2021.10.0-rc1/test/.. -I/home/brad/tmp/ffmpeg-ports/ports/pobj/tbb-2021.10.0-rc1/oneTBB-2021.10.0-rc1/test -I/home/brad/tmp/ffmpeg-ports/ports/pobj/tbb-2021.10.0-rc1/oneTBB-2021.10.0-rc1/src/tbb/../../include -O2 -pipe -DNDEBUG -std=c++11 -Wall -Wextra -Werror -Wshadow -Wcast-qual -Woverloaded-virtual -Wnon-virtual-dtor -ffp-model=precise -mrtm -mwaitpkg -Wformat -Wformat-security -Werror=format-security -fstack-protector-strong -fPIC -D_FORTIFY_SOURCE=2 -MD -MT test/CMakeFiles/test_eh_thread.dir/tbb/test_eh_thread.cpp.o -MF test/CMakeFiles/test_eh_thread.dir/tbb/test_eh_thread.cpp.o.d -o test/CMakeFiles/test_eh_thread.dir/tbb/test_eh_thread.cpp.o -c /home/brad/tmp/ffmpeg-ports/ports/pobj/tbb-2021.10.0-rc1/oneTBB-2021.10.0-rc1/test/tbb/test_eh_thread.cpp
FAILED: test/CMakeFiles/test_eh_thread.dir/tbb/test_eh_thread.cpp.o
/home/brad/tmp/ffmpeg-ports/ports/pobj/tbb-2021.10.0-rc1/bin/c++  -I/home/brad/tmp/ffmpeg-ports/ports/pobj/tbb-2021.10.0-rc1/oneTBB-2021.10.0-rc1/test/.. -I/home/brad/tmp/ffmpeg-ports/ports/pobj/tbb-2021.10.0-rc1/oneTBB-2021.10.0-rc1/test -I/home/brad/tmp/ffmpeg-ports/ports/pobj/tbb-2021.10.0-rc1/oneTBB-2021.10.0-rc1/src/tbb/../../include -O2 -pipe -DNDEBUG -std=c++11 -Wall -Wextra -Werror -Wshadow -Wcast-qual -Woverloaded-virtual -Wnon-virtual-dtor -ffp-model=precise -mrtm -mwaitpkg -Wformat -Wformat-security -Werror=format-security -fstack-protector-strong -fPIC -D_FORTIFY_SOURCE=2 -MD -MT test/CMakeFiles/test_eh_thread.dir/tbb/test_eh_thread.cpp.o -MF test/CMakeFiles/test_eh_thread.dir/tbb/test_eh_thread.cpp.o.d -o test/CMakeFiles/test_eh_thread.dir/tbb/test_eh_thread.cpp.o -c /home/brad/tmp/ffmpeg-ports/ports/pobj/tbb-2021.10.0-rc1/oneTBB-2021.10.0-rc1/test/tbb/test_eh_thread.cpp
In file included from /home/brad/tmp/ffmpeg-ports/ports/pobj/tbb-2021.10.0-rc1/oneTBB-2021.10.0-rc1/test/tbb/test_eh_thread.cpp:23:
/home/brad/tmp/ffmpeg-ports/ports/pobj/tbb-2021.10.0-rc1/oneTBB-2021.10.0-rc1/test/common/utils.h:361:17: error: comparison of integers of different signs: 'const int' and 'const unsigned int' [-Werror,-Wsign-compare]
    return left > right ? left : right;
           ~~~~ ^ ~~~~~
/home/brad/tmp/ffmpeg-ports/ports/pobj/tbb-2021.10.0-rc1/oneTBB-2021.10.0-rc1/test/tbb/test_eh_thread.cpp:78:40: note: in instantiation of function template specialization 'utils::max<int, unsigned int>' requested here
        std::size_t stacksize = utils::max(128*1024, PTHREAD_STACK_MIN);
                                       ^
1 error generated.

[pavelkumbrasev]

@ldorau and @lplewa Are you ok to disable test_malloc_compliance on OpenBSD since it doesn't have RLIMIT_AS?

[ldorau]

@ldorau and @lplewa Are you ok to disable test_malloc_compliance on OpenBSD since it doesn't have RLIMIT_AS?

Yes, it is OK for me.

[pavelkumbrasev]

@brad0 Could you please validate the last revision?

[brad0]

test_eh_thread.cpp builds.

[1/20] : && /home/brad/tmp/ffmpeg-ports/ports/pobj/tbb-2021.9.0/bin/c++ -O2 -pipe -DNDEBUG  test/CMakeFiles/test_malloc_compliance.dir/tbbmalloc/test_malloc_compliance.cpp.o -o clang_13.0_cxx11_64_release/test_malloc_compliance  -Wl,-z,origin,-rpath,/home/brad/tmp/ffmpeg-ports/ports/pobj/tbb-2021.9.0/build-amd64/clang_13.0_cxx11_64_release  clang_13.0_cxx11_64_release/libtbbmalloc.so.2.0  -Wl,-rpath-link,/usr/X11R6/lib:/usr/local/lib && :
FAILED: clang_13.0_cxx11_64_release/test_malloc_compliance
: && /home/brad/tmp/ffmpeg-ports/ports/pobj/tbb-2021.9.0/bin/c++ -O2 -pipe -DNDEBUG  test/CMakeFiles/test_malloc_compliance.dir/tbbmalloc/test_malloc_compliance.cpp.o -o clang_13.0_cxx11_64_release/test_malloc_compliance  -Wl,-z,origin,-rpath,/home/brad/tmp/ffmpeg-ports/ports/pobj/tbb-2021.9.0/build-amd64/clang_13.0_cxx11_64_release  clang_13.0_cxx11_64_release/libtbbmalloc.so.2.0  -Wl,-rpath-link,/usr/X11R6/lib:/usr/local/lib && :
ld: error: undefined symbol: main
>>> referenced by /usr/lib/crt0.o:(.text+0x14E)
c++: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.

[pavelkumbrasev]

ld: error: undefined symbol: main

Oh, sorry, that was not obvious. Could you please test it one more time?

[brad0]

Yes, that builds. Thanks.

[dnmokhov]

LGTM