Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For emscriptem, remove Intel(R) Transactional Synchronization Extensions (-mrtm) and WAITPKG instructions support (-mwaitpkg) #1271

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

JhaShweta1
Copy link
Contributor

Description

WASM: build fails for Emscripten 3.1.45, because Intel(R) Transactional Synchronization Extensions (-mrtm) and WAITPKG instructions support (-mwaitpkg) are not supported

Fixes # - 1266

  • - git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details)

Type of change

Choose one or multiple, leave empty if none of the other choices apply

Add a respective label(s) to PR if you have permissions

  • [X ] bug fix - change that fixes an issue
  • new feature - change that adds functionality
  • tests - change in tests
  • infrastructure - change in infrastructure and CI
  • documentation - documentation update

Tests

  • added - required for new features and some bug fixes
  • [ x] not needed

Documentation

  • updated in # - add PR number
  • needs to be updated
  • [x ] not needed

Breaks backward compatibility

  • Yes
  • [x ] No
  • Unknown

Notify the following users

List users with @ to send notifications

Other information

@pavelkumbrasev pavelkumbrasev linked an issue Nov 21, 2023 that may be closed by this pull request
Copy link
Contributor

@isaevil isaevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JhaShweta1 JhaShweta1 merged commit 8259efb into master Nov 27, 2023
20 checks passed
@JhaShweta1 JhaShweta1 deleted the dev/shwetajh/emscriptem-mrtm-waitpkg branch November 27, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WASM: build fails for Emscripten 3.1.45+
2 participants