[try_put_and_wait] Part 1: Add implementation of try_put_and_wait feature for function_node #1398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kboyarinov
requested review from
aleksei-fedotov,
vossmjp,
pavelkumbrasev,
dnmokhov and
isaevil
dnmokhov
reviewed
Jun 18, 2024
kboyarinov
changed the title
kboyarinov
commented
Jul 5, 2024
Co-authored-by: Aleksei Fedotov <[email protected]>
vossmjp
reviewed
Jul 22, 2024
| test_try_put_and_wait_queueing(tbb::flow::unlimited); | ||
|
|
||
| test_try_put_and_wait_rejecting(tbb::flow::serial); | ||
| // TODO: add integration test with buffering node before rejecting function_node |
There was a problem hiding this comment.
I suppose I would expect additional tests that have fan-out and fan-in to the function_node and perhaps more than one overlapping tracked message. But I suppose these would not be unique tests to function_node but be a broader test. Will there be such tests?
There was a problem hiding this comment.
Yes, current tests are just basic tests for waiting only for jobs required to execute wait_message and not waiting for any other tasks in the graph. Some tests for tricky graphs should be added for each node types in the future. Can it be considered as a future improvements for testing?
Merged
13 tasks
…production' into dev/kboyarinov/try_put_and_wait_function_node
kboyarinov
merged commit 35358fd
into
dev/kboyarinov/try_put_and_wait_production
21 of 22 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extend function_node (queueing, rejecting, lightweight) with the new try_put_and_wait API for waiting on single messages.
Add basic functionality such as message_metainfo and basic try_put_and_wait function.
Fixes # - issue number(s) if exists
Type of change
Choose one or multiple, leave empty if none of the other choices apply
Add a respective label(s) to PR if you have permissions
Tests
Documentation
Breaks backward compatibility
Notify the following users
List users with
@to send notificationsOther information